You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by alasdairhodge <gi...@git.apache.org> on 2015/02/24 12:35:14 UTC
[GitHub] incubator-brooklyn pull request: LocationTransformer: generate cor...
GitHub user alasdairhodge opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/526
LocationTransformer: generate correct location spec strings
Correctly deals with `Maybe` values to avoid spurious warnings like:
````
WARN Location resolution failed for 'Present[value=localhost]' (will fail shortly):
known resolvers are: [id, named, localhost, byon, single, host, multi, portForwardManager, jclouds, jcloudsByon, pool]
````
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alasdairhodge/incubator-brooklyn maybe-aware-location-resolution
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/526.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #526
----
commit d1e4637eb19fdf912d804870a06840f3f3982998
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-02-24T10:49:28Z
LocationTransformer: generate correct location spec strings from 'Maybe' values
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: LocationTransformer: generate cor...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/526#issuecomment-76010119
One other minor comment: can you stick to approx 50 chars for first line of commit message:
https://github.com/erlang/otp/wiki/Writing-good-commit-messages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: LocationTransformer: generate cor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: LocationTransformer: generate cor...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/526#issuecomment-76009664
@alasdairhodge Looks good; nice and simple. Would be nice to have a unit test in the spirit of writing a unit test for failing functionality to avoid regressions. Will leave that to you for future work as you see fit.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---