[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #83: RATIS-901. Fix Failed UT: WatchRequestTests.testWatchRequestClientTimeout

[GitBox <gi...@apache.org>]

runzhiwang commented on a change in pull request #83:
URL: https://github.com/apache/incubator-ratis/pull/83#discussion_r419060759



##########
File path: ratis-server/src/test/java/org/apache/ratis/WatchRequestTests.java
##########
@@ -457,8 +460,13 @@ static void runTestWatchRequestClientTimeout(TestParameters p) throws Exception
           ex.getCause().getClass());
       if (ex.getCause() != null) {
         if (ex.getCause().getCause() != null) {
-          Assert.assertEquals(TimeoutIOException.class,
-              ex.getCause().getCause().getClass());
+          // when client closed and throw TimeoutException,
+          // RaftClientImpl::handleIOException will random select a leader
+          // because suggested new leader is null.

Review comment:
       @bshashikant Thanks for your review. I have updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org