You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2022/12/24 12:50:00 UTC
[jira] [Commented] (SOLR-10467) setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651785#comment-17651785 ]
Eric Pugh commented on SOLR-10467:
----------------------------------
I might need a pairing session on this one! this isn't just a move from a CloudSolrClient to a builder method, as it involves a seperate class ZkClientClusterStateProvider. I *think* the idea is that we have a either a new method on the builder that is a withZkClientClusterStateProvider... or that by having the setZkConnectTimeout on the builder of the client, then we have that method on build delegae to a zkClientClusterStateProvider....
> setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods
> ------------------------------------------------------------------------------
>
> Key: SOLR-10467
> URL: https://issues.apache.org/jira/browse/SOLR-10467
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 7.0
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setZkConnectTimeout}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org