[GitHub] [carbondata] akkio-97 commented on a change in pull request #3869: [CARBONDATA-3939]Exception added for index creation on long string columns

[GitBox <gi...@apache.org>]

akkio-97 commented on a change in pull request #3869:
URL: https://github.com/apache/carbondata/pull/3869#discussion_r464318621



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/command/SICreationCommand.scala
##########
@@ -253,6 +253,17 @@ private[sql] case class CarbonCreateSecondaryIndexCommand(
         throw new ErrorMessage(
           s"Table [$tableName] under database [$databaseName] is already an index table")
       }
+      // creation of index on long string columns are not supported
+      for (indexColName <- indexModel.columnNames) {
+        for (dim <- dims) {
+          if (indexColName.equals(dim.getColName) && dim.getDataType.getName.equals("VARCHAR")) {
+            throw new ErrorMessage(
+              s"one or more index columns specified cannot be of Long String property" +
+              s" column in table $databaseName.$tableName")
+          }
+        }
+      }
+

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org