[jira] [Comment Edited] (SLING-7798) Switch from JSR-305 annotations to Jetbrains Nullable/NotNull Annotations

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574833#comment-16574833 ] 

Carsten Ziegeler edited comment on SLING-7798 at 8/9/18 1:42 PM:
-----------------------------------------------------------------

I went ahead and converted the following modules (as we most likely will release them shortly):
api
installer.core
jcr.resource
resourceresolver



was (Author: cziegeler):
I went ahead and converted the following modules (as we most likely will release them shortly):
api
resourceresolver
jcr.resource


> Switch from JSR-305 annotations to Jetbrains Nullable/NotNull Annotations 
> --------------------------------------------------------------------------
>
>                 Key: SLING-7798
>                 URL: https://issues.apache.org/jira/browse/SLING-7798
>             Project: Sling
>          Issue Type: Improvement
>          Components: General
>            Reporter: Stefan Seifert
>            Priority: Major
>             Fix For: Parent 34
>
>
> follow-up from SLING-7312 and discussion from the [mailing list|https://lists.apache.org/thread.html/44cac2f3c9454a308b70adb9c73a8e9a928d9c145a12f82f8a3a0ef1@%3Cdev.sling.apache.org%3E].
> i will also start a vote on the mailing list about this, but this ticket describes the steps that are required.
> about the jetbrains annotations:
> * documentation: https://www.jetbrains.com/help/idea/nullable-and-notnull-annotations.html
> * artifact: http://repo1.maven.org/maven2/org/jetbrains/annotations/16.0.2/
> * although from jetbrans created for IntelliJ, they are also support by most other tooling (e.g. findbugs, sonar, configurable in Eclipse)
> * apache 2.0 licensed: https://github.com/JetBrains/java-annotations
> [this search|https://issues.apache.org/jira/browse/SLING-7312?focusedCommentId=16565479#comment-16565479] turned out that these modules are currently using JSR-305 annotations and need to be converted:
> * org-apache-sling-api/pom.xml
> * org-apache-sling-auth-core/pom.xml
> * org-apache-sling-caconfig-api/pom.xml
> * org-apache-sling-caconfig-impl/pom.xml
> * org-apache-sling-caconfig-spi/pom.xml
> * org-apache-sling-commons-clam/pom.xml
> * org-apache-sling-commons-messaging/pom.xml
> * org-apache-sling-commons-messaging-mail/pom.xml
> * org-apache-sling-discovery-commons/pom.xml
> * org-apache-sling-distribution-api/pom.xml
> * org-apache-sling-distribution-avro-serializer/pom.xml
> * org-apache-sling-distribution-core/pom.xml
> * org-apache-sling-distribution-kryo-serializer/pom.xml
> * org-apache-sling-installer-core/pom.xml
> * org-apache-sling-jcr-api/pom.xml
> * org-apache-sling-jcr-resource/pom.xml
> * org-apache-sling-jms/pom.xml
> * org-apache-sling-jobs/pom.xml
> * org-apache-sling-jobs-it-services/pom.xml
> * org-apache-sling-models-api/pom.xml
> * org-apache-sling-models-impl/pom.xml
> * org-apache-sling-models-jacksonexporter/pom.xml
> * org-apache-sling-models-validation-impl/pom.xml
> * org-apache-sling-mom/pom.xml
> * org-apache-sling-oak-restrictions/pom.xml
> * org-apache-sling-resource-presence/pom.xml
> * org-apache-sling-resourceresolver/pom.xml
> * org-apache-sling-scripting-core/pom.xml
> * org-apache-sling-scripting-sightly/pom.xml
> * org-apache-sling-scripting-thymeleaf/pom.xml
> * org-apache-sling-tracer/pom.xml
> * org-apache-sling-validation-api/pom.xml
> * org-apache-sling-validation-core/pom.xml
> * org-apache-sling-validation-test-services/pom.xml
> * org-apache-sling-xss/pom.xml
> * parent/pom.xml
> * whiteboard/encrypt/pom.xml
> * whiteboard/project-archetype/src/main/resources/archetype-resources/pom.xml
> * whiteboard/scripting-resolver/org-apache-sling-scripting-resolver/pom.xml
> steps to do:
> # convert java sources and poms to jetbrains annotations and update package versions with the help of the {{convert-annotations.sh}} from OAK-7511 provided by [~reschke] described [here|https://issues.apache.org/jira/browse/SLING-7312?focusedCommentId=16565603#comment-16565603]
> # update sling documentation: https://sling.apache.org/documentation/development/jsr-305.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)