You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/04/21 13:29:25 UTC

[GitHub] [openwhisk] upgle commented on a change in pull request #4887: Add RestartSource to restart failing Kafka consumer for user-events service

upgle commented on a change in pull request #4887:
URL: https://github.com/apache/openwhisk/pull/4887#discussion_r412184898



##########
File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/OpenWhiskEvents.scala
##########
@@ -29,11 +29,14 @@ import org.apache.kafka.common.serialization.StringDeserializer
 import pureconfig._
 import pureconfig.generic.auto._
 
+import scala.concurrent.duration.FiniteDuration
 import scala.concurrent.{ExecutionContext, Future}
 
 object OpenWhiskEvents extends SLF4JLogging {
 
-  case class MetricConfig(port: Int, enableKamon: Boolean, ignoredNamespaces: Set[String])
+  case class MetricConfig(port: Int, enableKamon: Boolean, ignoredNamespaces: Set[String], retry: RetryConfig)
+
+  case class RetryConfig(minBackoff: FiniteDuration, maxBackoff: FiniteDuration, randomFactor: Double, maxRestarts: Int)

Review comment:
       @chetanmeh Thank you for your review. I've used the same Configuration class here.   
   https://github.com/apache/openwhisk/pull/4632/files#diff-3753d510c1485477c63054dde55b759dR39




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org