[jira] [Commented] (HADOOP-15567) Support expiry time in AdlFileSystem

["Íñigo Goiri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773306#comment-16773306 ] 

Íñigo Goiri commented on HADOOP-15567:
--------------------------------------

Thanks [~huanbang1993] for the work.
Minor comments:
* Can we make {{EXPIRY_TIME_DURATION = TimeUnit.DAYS.toMillis(7)}}.
* Can you make the constants (EPS and EXPIRY_TIME_DURATION ) final?
* Not sure we need EPS, by the way assertEquals has a method for the check with difference: assertEquals(EXPIRY_TIME_DURATION, diff, 500L);
* We should make {{assertPathExist()}} a little more friendly and report that the file does not exists in the message.
* When expecting exceptions, we should use LambaUtils or exception rules.

> Support expiry time in AdlFileSystem
> ------------------------------------
>
>                 Key: HADOOP-15567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15567
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Íñigo Goiri
>            Assignee: Anbang Hu
>            Priority: Major
>         Attachments: HADOOP-15567.000.patch, HADOOP-15567.001.patch, live-test-result.png
>
>
> ADLS supports setting an expiration time for a file.
> We can leverage Xattr in FileSystem to set the expiration time.
> This could use the same xattr as HDFS-6382 and the interface from HDFS-6525.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org