[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE

["heyihong (via GitHub)" <gi...@apache.org>]

heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339979053


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
     @deprecated(message = "Please use create() instead.", since = "3.5.0")
     def build(): SparkSession = create()
 
+    private def getClientConfiguration(): Configuration = {
+      // Use copy() to avoid modifying the state of the existing builder.
+      builder.copy().loadFromEnvironment().configuration

Review Comment:
   SPARK_REMOTE value makes the final override before [RemoteSparkSession.builder.config(map=opts).getOrCreate()](https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L479) if I understand correctly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org