You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2018/08/14 15:54:18 UTC
httpcomponents-client git commit: Better local var names.
Repository: httpcomponents-client
Updated Branches:
refs/heads/4.5.x 82ccfe69f -> 6c51823fd
Better local var names.
Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/6c51823f
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/6c51823f
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/6c51823f
Branch: refs/heads/4.5.x
Commit: 6c51823fdc27348f4f8afc01b7e5967b7da2e200
Parents: 82ccfe6
Author: Gary Gregory <ga...@gmail.com>
Authored: Tue Aug 14 09:54:16 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Tue Aug 14 09:54:16 2018 -0600
----------------------------------------------------------------------
.../http/impl/cookie/DefaultCookieSpec.java | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/6c51823f/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java
----------------------------------------------------------------------
diff --git a/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java b/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java
index 670a296..88264a0 100644
--- a/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java
+++ b/httpclient/src/main/java/org/apache/http/impl/cookie/DefaultCookieSpec.java
@@ -105,10 +105,10 @@ public class DefaultCookieSpec implements CookieSpec {
final CookieOrigin origin) throws MalformedCookieException {
Args.notNull(header, "Header");
Args.notNull(origin, "Cookie origin");
- HeaderElement[] helems = header.getElements();
+ HeaderElement[] hElems = header.getElements();
boolean versioned = false;
boolean netscape = false;
- for (final HeaderElement helem: helems) {
+ for (final HeaderElement helem: hElems) {
if (helem.getParameterByName("version") != null) {
versioned = true;
}
@@ -128,20 +128,20 @@ public class DefaultCookieSpec implements CookieSpec {
((FormattedHeader) header).getValuePos(),
buffer.length());
} else {
- final String s = header.getValue();
- if (s == null) {
+ final String hValue = header.getValue();
+ if (hValue == null) {
throw new MalformedCookieException("Header value is null");
}
- buffer = new CharArrayBuffer(s.length());
- buffer.append(s);
+ buffer = new CharArrayBuffer(hValue.length());
+ buffer.append(hValue);
cursor = new ParserCursor(0, buffer.length());
}
- helems = new HeaderElement[] { parser.parseHeader(buffer, cursor) };
- return netscapeDraft.parse(helems, origin);
+ hElems = new HeaderElement[] { parser.parseHeader(buffer, cursor) };
+ return netscapeDraft.parse(hElems, origin);
}
return SM.SET_COOKIE2.equals(header.getName())
- ? strict.parse(helems, origin)
- : obsoleteStrict.parse(helems, origin);
+ ? strict.parse(hElems, origin)
+ : obsoleteStrict.parse(hElems, origin);
}
@Override