[GitHub] [maven] gnodet commented on a change in pull request #472: [MNG-6915] Adapt the logging width to the terminal width, including sensible limits.

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #472:
URL: https://github.com/apache/maven/pull/472#discussion_r632533500



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
##########
@@ -53,9 +54,15 @@
 {
     private final Logger logger;
 
-    private static final int LINE_LENGTH = 72;
+    private static final int MAX_LOG_PREFIX_SIZE = 8; // "[ERROR] "
+    private static final int PROJECT_STATUS_SUFFIX_SIZE = 20; // "SUCCESS [  0.000 s]"
+    private static final int MIN_TERMINAL_WIDTH = 60;
+    private static final int MAX_TERMINAL_WIDTH = 130;
+    private static final int TERMINAL_WIDTH =
+            Math.min( MAX_TERMINAL_WIDTH, Math.max( MessageUtils.getTerminalWidth(), MIN_TERMINAL_WIDTH ) );

Review comment:
       I don't think this is a good idea to use a constant for the terminal width.  In the case where the maven class loader is reused, the terminal could change its width.  What about computing this variable and caching it for the `MavenSession` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org