You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/17 08:13:48 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3188: ARTEMIS-2807 avoid notifications on critical IO error

michaelandrepearce commented on a change in pull request #3188:
URL: https://github.com/apache/activemq-artemis/pull/3188#discussion_r441363994



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1071,6 +1071,11 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
          }
          state = SERVER_STATE.STOPPING;
 
+         if (criticalIOError) {
+            // notifications trigger disk IO so we don't want to send any on a critical IO error

Review comment:
       Why would i not want to know about critical errors on the management notification channel. This doesnt make sense to me




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org