You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by "David Binderman (JIRA)" <ji...@apache.org> on 2014/03/25 20:28:14 UTC

[jira] [Created] (TS-2663) [HttpTransactHeaders.cc:622]: (style) Same expression on both sides of '||'.

David Binderman created TS-2663:
-----------------------------------

             Summary: [HttpTransactHeaders.cc:622]: (style) Same expression on both sides of '||'.
                 Key: TS-2663
                 URL: https://issues.apache.org/jira/browse/TS-2663
             Project: Traffic Server
          Issue Type: Bug
            Reporter: David Binderman


Source code is

    if (log_code == SQUID_LOG_TCP_MISS || log_code == SQUID_LOG_TCP_MISS) {

Judging by code a few lines further down, maybe the following
code was intended

   if (log_code == SQUID_LOG_TCP_MISS || log_code == SQUID_LOG_TCP_IMS_MISS) {

I found this possible problem by using cppcheck, a static analysis checker.




--
This message was sent by Atlassian JIRA
(v6.2#6252)