You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/06 09:47:25 UTC
[GitHub] [flink-table-store] SteNicholas opened a new pull request, #355: Bump Flink version to 1.16.0
SteNicholas opened a new pull request, #355:
URL: https://github.com/apache/flink-table-store/pull/355
Flink 1.16.0 version has already released. Bump Flink version to 1.16.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #355: Bump Flink version to 1.16.0
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #355:
URL: https://github.com/apache/flink-table-store/pull/355#discussion_r1014968244
##########
flink-table-store-connector/src/main/1.16.0/org/apache/flink/table/store/connector/TableConfigUtils.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.connector;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.api.TableConfig;
+
+/** Utils for {@link TableConfig}. */
+public class TableConfigUtils {
Review Comment:
Can we introduce a `flink.shade.version` to pom?
Then we can use `1.14` for flink 1.14. And use `1.15` to both flink 1.15 and flink 1.16.
In this way, we don't need to copy these classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on pull request #355: [FLINK-29933] Bump Flink version to 1.16.0
Posted by GitBox <gi...@apache.org>.
LadyForest commented on PR #355:
URL: https://github.com/apache/flink-table-store/pull/355#issuecomment-1308310681
I found that It's failed to build hive-3.1 with flink-1.15 after introduce this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #355: Bump Flink version to 1.16.0
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #355:
URL: https://github.com/apache/flink-table-store/pull/355#discussion_r1014968244
##########
flink-table-store-connector/src/main/1.16.0/org/apache/flink/table/store/connector/TableConfigUtils.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.store.connector;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.api.TableConfig;
+
+/** Utils for {@link TableConfig}. */
+public class TableConfigUtils {
Review Comment:
Can we introduce a `flink.shade.version` to pom?
Then we can use `1.14` for flink 1.14. And use `1.15` to both flink 1.15 and flink 1.16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #355: [FLINK-29933] Bump Flink version to 1.16.0
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #355:
URL: https://github.com/apache/flink-table-store/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org