Re: mod_negotiation/1987: Apache dumps core when handling unacceptable variants

[Martin Plechsmid <pl...@karlin.mff.cuni.cz>]

The following reply was made to PR mod_negotiation/1987; it has been noted by GNATS.

From: Martin Plechsmid <pl...@karlin.mff.cuni.cz>
To: lars@Apache.Org
Cc: apbugs@Apache.Org
Subject: Re: mod_negotiation/1987: Apache dumps core when handling unacceptable variants
Date: Sat, 3 Oct 1998 22:22:42 +0200 (MET DST)

 The bug is still present in Apache 1.3.1, and nothing has changed about it in 1.3.2. So it's there also.
 
 >How-to-repeat:
 Uncoment "#define  TCN_02" at the beggining of the file mod_negotiation.c and recompile server.
 Put files "xxx.html.en" and "xxx.html.fr" into a directory and send the following headers to the server:
 
 GET /..../xxx.html HTTP/1.0
 Negotiate: 1.0
 Accept-Language: it
 
 The server will crash.
 
 >Fix:
 The following patch for Apache 1.3.1 solves the problem:
 
 --- mod_negotiation.c.orig      Sat Oct  3 22:05:04 1998
 +++ mod_negotiation.c   Sat Oct  3 22:06:27 1998
 @@ -1566,6 +1566,7 @@
              variant->definite);
  #endif
  
 +    if (q == 0)  return 0;
      if (q > bestq) {
          *p_bestq = q;
          return 1;