[GitHub] [maven-surefire] Tibor17 commented on issue #256: repackaged external artifacts (utilities) with no duplicates and use in extensions-api with Commandline

[GitBox <gi...@apache.org>]

Tibor17 commented on issue #256: repackaged external artifacts (utilities) with no duplicates and use in extensions-api with Commandline
URL: https://github.com/apache/maven-surefire/pull/256#issuecomment-560211922
 
 
   @jon-bell 
   This is a preliminary step to the sockets. We discussed it on Slack.
   
   Briefly what this provides.
   Module `surefire-extensions-api` dependent on `maven-shared-utils` caused that the project could not be compiled (problem with relocated packages). Relocating the packages is important.
   
   - Finally the first commit made `surefire-extensions-api` dependent on relocated packages and the project can be compiled. The module `surefire-extensions-api` can use the class `Commandline` in public contructor.
   - The subtypes of `Channel` are applicable to pipes and sockets Java API too - compatible, see `1ba5e55`.
   - We got rid of the problems with flushing the streams in higher version of `executeCommandLineAsCallable()` of the artifact `maven-shared-utils`. 
   - The impl of future commits would be just one method call (for the proces call) with everything inside of the extension impl, see `71b8fd3`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services