You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Conan <co...@gmail.com> on 2011/12/14 17:58:21 UTC
get combo_handler compiled and work
hi,
I modified the combo_handler's code (almost API migration work) , and it
works. If you want a try, here is the reference.
Combo_handler requires ESI's code and I can't make ESI work, so I copy
ESI's code to combo_handler's directory and write a Makefile.
combo_handler
|____combo_handler.cc
|____fetcher
| |____FetchedDataProcessor.h
| |____HttpDataFetcher.h
| |____HttpDataFetcherImpl.cc
| |____HttpDataFetcherImpl.h
|____lib
| |____Attribute.h
| |____ComponentBase.h
| |____DocNode.cc
| |____DocNode.h
| |____EsiParser.cc
| |____EsiParser.h
| |____EsiProcessor.cc
| |____EsiProcessor.h
| |____Expression.cc
| |____Expression.h
| |____FailureInfo.cc
| |____FailureInfo.h
| |____gzip.cc
| |____gzip.h
| |____HandlerManager.cc
| |____HandlerManager.h
| |____HttpHeader.h
| |____IncludeHandlerFactory.h
| |____SpecialIncludeHandler.h
| |____Stats.cc
| |____Stats.h
| |____StringHash.h
| |____Utils.cc
| |____Utils.h
| |____Variables.cc
| |____Variables.h
|____LICENSE
|____Makefile
|____README
Attachment is the patch based on current trunk (Revision 1212139). I'm
not familiar with http-transform API, so you'd better review it.
This plugin works on 3.1 trunk.
For 3.0.2, you should backport
http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/InkAPI.cc?r1=1153581&r2=1153660
Re: get combo_handler compiled and work
Posted by Conan <co...@gmail.com>.
hi igalic.
2011/12/15 Igor Galić <i....@brainsware.org>
>
>
> ----- Original Message -----
> > hi,
>
> Hi Conan,
>
> > I modified the combo_handler's code (almost API migration work) , and
> > it works. If you want a try, here is the reference.
>
> IIRC, getting combo_handler to work for me was just a matter of
> s/INK/TS/g
>
> My patch bases on your "s/INK/TS/g".
> > Combo_handler requires ESI's code and I can't make ESI work, so I
> > copy ESI's code to combo_handler's directory and write a Makefile.
>
> The problem really is finding an appropriate way to use
> the 'lib' directory in ESI for both project in a satisfactory way.
> I'm thinking of extracting it from esi and putting it in
> /plugins/trunk/lib
>
I tried your ESI makefile. It can be compiled but fail when dlopen it in
ATS ( "symbol not found" ). I think should compile more code in esi/lib
esi/fetcher and link together. Now still many compile fail for the code in
lib/*.cc. If ESI work, Nick's libloader may help.
> Feedback on this would also be very welcome.
>
> [snip]
>
>
> > Attachment is the patch based on current trunk (Revision 1212139).
>
> Nope, it's not :)
>
> patch seem not attached. do again.
> > I'm not familiar with http-transform API, so you'd better review it.
>
> I'd love to, once you send it.
> Of if you were to create a Jira issue, that would be great!
> (if you look at our CHANGES file, you'll see that everything is linked
> to a Jira issue - that's sort of become the way we work)
>
> I'll file a jira later.
> > This plugin works on 3.1 trunk.
> > For 3.0.2, you should backport
> >
> http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/InkAPI.cc?r1=1153581&r2=1153660
>
> *I* think, this is for the same version not back-portable (right now)
> as TS-1037 - because it relies on having the IPv6 refactoring back-
> ported.
>
> Ok.
> So long,
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
>
Re: get combo_handler compiled and work
Posted by Igor Galić <i....@brainsware.org>.
----- Original Message -----
> hi,
Hi Conan,
> I modified the combo_handler's code (almost API migration work) , and
> it works. If you want a try, here is the reference.
IIRC, getting combo_handler to work for me was just a matter of
s/INK/TS/g
> Combo_handler requires ESI's code and I can't make ESI work, so I
> copy ESI's code to combo_handler's directory and write a Makefile.
The problem really is finding an appropriate way to use
the 'lib' directory in ESI for both project in a satisfactory way.
I'm thinking of extracting it from esi and putting it in
/plugins/trunk/lib
Feedback on this would also be very welcome.
[snip]
> Attachment is the patch based on current trunk (Revision 1212139).
Nope, it's not :)
> I'm not familiar with http-transform API, so you'd better review it.
I'd love to, once you send it.
Of if you were to create a Jira issue, that would be great!
(if you look at our CHANGES file, you'll see that everything is linked
to a Jira issue - that's sort of become the way we work)
> This plugin works on 3.1 trunk.
> For 3.0.2, you should backport
> http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/InkAPI.cc?r1=1153581&r2=1153660
*I* think, this is for the same version not back-portable (right now)
as TS-1037 - because it relies on having the IPv6 refactoring back-
ported.
So long,
i
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE