You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/04 01:09:41 UTC

[GitHub] [kafka] splett2 opened a new pull request #9685: KAFKA-10748: Add IP connection rate throttling metric

splett2 opened a new pull request #9685:
URL: https://github.com/apache/kafka/pull/9685


   This PR adds the IP throttling metric as described in KIP-612.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] apovzner commented on a change in pull request #9685: KAFKA-10748: Add IP connection rate throttling metric

Posted by GitBox <gi...@apache.org>.
apovzner commented on a change in pull request #9685:
URL: https://github.com/apache/kafka/pull/9685#discussion_r537955330



##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -1753,9 +1761,9 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics: Metrics) extend
      * The average is out of all throttle times > 0, which is consistent with the bandwidth and request quota throttle

Review comment:
       need to update comment for this method, because the beginning of the comment says that throttle is `due to hitting connection rate quota.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #9685: KAFKA-10748: Add IP connection rate throttling metric

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #9685:
URL: https://github.com/apache/kafka/pull/9685


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org