[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319337464
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java
 ##########
 @@ -408,6 +414,23 @@ public void setTxnCommitAttachment(TxnCommitAttachment txnCommitAttachment) {
         this.txnCommitAttachment = txnCommitAttachment;
     }
     
+    public void addTableIndexes(OlapTable table) {
 
 Review comment:
   Does this function can be called by multi threads? If so you should make this function thread-safe, otherwise you should add some comments for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org