You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2018/04/18 04:42:00 UTC
[jira] [Commented] (SOLR-12233) QParserPlugin maintains a list of
classes recreated every time a Solrcore object is created
[ https://issues.apache.org/jira/browse/SOLR-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441887#comment-16441887 ]
Shawn Heisey commented on SOLR-12233:
-------------------------------------
Are you *absolutely certain* that all of the QParserPlugin implementations are safe to have one instance shared between all SolrCore objects? How much testing has been done with this patch?
At first glance (looking at only a few of them) they do look a little bit like factory classes -- each one has an implementation of the abstract method createParser, and it looks like a parser is probably created for every request.
> QParserPlugin maintains a list of classes recreated every time a Solrcore object is created
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-12233
> URL: https://issues.apache.org/jira/browse/SOLR-12233
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 7.1.1
> Reporter: Jeff Miller
> Assignee: Erick Erickson
> Priority: Minor
> Labels: Performance, qparserplugin
> Time Spent: 10m
> Remaining Estimate: 0h
>
> QParserPlugin maintains a static map of Class Names to Class objects and everytime we create a SolrCore object this causes a lot of overhead doing classloader lookups. Our system runs a lot of cores and the classloader gets bogged down when a lot of threads are creating solrcore objects.
> There's no need to create these objects every time, similar classes such as
> TransformerFactory store the object one time and reference it over and over again
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org