You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/18 09:40:18 UTC
[GitHub] [cloudstack] slavkap opened a new pull request, #6909: KVM support of iothreads
slavkap opened a new pull request, #6909:
URL: https://github.com/apache/cloudstack/pull/6909
### Description
Support of `iothreads` for KVM hypervisors through a VM template
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1386967159
@DaanHoogland, it would be great if this could get in for 4.18, but it depends on how much work I will have after the reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
wido commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396661606
> @nvazquez @wido has either of you tested this?
No, I do not have a testing bed for this. I should have commented: 'Code LGTM'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396926484
tnx @nvazquez
> It was code review sorry @DaanHoogland, let me test it this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1400050803
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1382192331
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [13.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1387028856
marking it for 4.18.0 tentatively @slavkap . hope you manage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1401545232
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1400049353
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291913
Thanks, @wido! A lot has changed from the initial idea, but I think it's ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
wido commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1080828276
##########
agent/conf/agent.properties:
##########
@@ -398,3 +395,6 @@ iscsi.session.cleanup.enabled=false
#consoleproxy.httpListenPort=443
#ping.retries=5
+
+# The number of iothreads. There should be only 1 or 2 IOThreads per VM CPU (default is 1)
Review Comment:
Maybe add a comment here that a value >1 is rarely used and people shouldn't touch this? IIRC there is no reason to go higher then 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1402607303
<b>Trillian test result (tid-5979)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6909-t5979-kvm-centos7.zip
Smoke tests completed. 102 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.91 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.13 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.22 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 112.91 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 80.24 | test_nonstrict_affinity_group.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 31.96 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 59.60 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 40.18 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 37.97 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 127.50 | test_kubernetes_clusters.py
test_01_secure_vm_migration | `Error` | 152.43 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 266.21 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 136.80 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.84 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.85 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1319956327
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6909](https://codecov.io/gh/apache/cloudstack/pull/6909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95a3395) into [main](https://codecov.io/gh/apache/cloudstack/commit/c5e657ddd80faa93585aef1381e30b7e2d9a9eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5e657d) will **increase** coverage by `0.00%`.
> The diff coverage is `38.09%`.
```diff
@@ Coverage Diff @@
## main #6909 +/- ##
=========================================
Coverage 10.87% 10.87%
Complexity 7117 7117
=========================================
Files 2485 2485
Lines 245507 245554 +47
Branches 38334 38349 +15
=========================================
+ Hits 26699 26715 +16
- Misses 215538 215562 +24
- Partials 3270 3277 +7
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ud/hypervisor/kvm/storage/KVMStorageProcessor.java](https://codecov.io/gh/apache/cloudstack/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9LVk1TdG9yYWdlUHJvY2Vzc29yLmphdmE=) | `4.98% <0.00%> (-0.02%)` | :arrow_down: |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `12.85% <0.00%> (-0.02%)` | :arrow_down: |
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `6.70% <0.00%> (-0.01%)` | :arrow_down: |
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `17.04% <47.36%> (+0.01%)` | :arrow_up: |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/6909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `67.30% <50.00%> (-0.36%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396182835
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1387052677
thanks @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1363676720
@wido, if you are talking about the IO policy, it could be set there, yes. But if the VM has a mixed type of volumes, probably it's a better option for each of them the IO policy to come from the storage pool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1382059190
> > @wido, if you are talking about the IO policy, it could be set there, yes. But if the VM has a mixed type of volumes, probably it's a better option for each of them the IO policy to come from the storage pool
>
> Check, because the description of the PR says:
>
> `This can be set from the primary storage setting kvm.storage.pool.io.policy`
>
> That didn't tell it can also be set per VM.
>
> So we can set this per VM and per Primary Storage pool, correct?
Hi @wido, I meant that it could be set but I didn't implement it. Now I did. I will update my description later, on how it could be used.
Thanks for the review! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1354392569
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1384053901
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1400140812
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1402678531
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
wido commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1363751737
> @wido, if you are talking about the IO policy, it could be set there, yes. But if the VM has a mixed type of volumes, probably it's a better option for each of them the IO policy to come from the storage pool
Check, because the description of the PR says:
```This can be set from the primary storage setting kvm.storage.pool.io.policy```
That didn't tell it can also be set per VM.
So we can set this per VM and per Primary Storage pool, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1073592017
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java:
##########
@@ -319,6 +326,14 @@ public Map<String, String> getDetails() {
customparameterMap.put("rootdisksize", rootdisksize.toString());
}
+ if (getIoDriverPolicy() != null) {
+ customparameterMap.put(VmDetailConstants.IO_POLICY, getIoDriverPolicy().toString());
+ }
+
+ if (iothreadsEnabled != null && iothreadsEnabled) {
Review Comment:
Can replace for BooleanUtils.toBoolean() ?
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java:
##########
@@ -319,6 +326,14 @@ public Map<String, String> getDetails() {
customparameterMap.put("rootdisksize", rootdisksize.toString());
}
+ if (getIoDriverPolicy() != null) {
+ customparameterMap.put(VmDetailConstants.IO_POLICY, getIoDriverPolicy().toString());
Review Comment:
Just a small refactor, can we invoke getIoDriverPolicy() once before the if block and use the value here so we don't have to invoke it again?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3055,24 +3073,34 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
- protected void setDiskIoDriver(DiskDef disk) {
- if (enableIoUring) {
- disk.setIoDriver(DiskDef.IoDriver.IOURING);
+ public void setDiskIoDriver(DiskDef disk, IoDriverPolicy ioDriver) {
+ s_logger.debug(String.format("Disk IO driver policy [%s]. The host supports the io_uring policy [%s]", ioDriver, enableIoUring));
+ if (ioDriver != null) {
+ if (IoDriverPolicy.IOURING != ioDriver) {
Review Comment:
Can we collapse this if block into one line?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1063,8 +1064,7 @@ public boolean configure(final String name, final Map<String, Object> params) th
}
// Enable/disable IO driver for Qemu (in case it is not set CloudStack can also detect if its supported by qemu)
- Boolean enableIoUringConfig = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.ENABLE_IO_URING);
Review Comment:
If this property is being deprecated, can we remove it from agent.properties as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396053959
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [15.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1402679105
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on a diff in pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
wido commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1056194243
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -69,6 +69,13 @@
*/
public static final Property<Integer> VM_MEMBALLOON_STATS_PERIOD = new Property<>("vm.memballoon.stats.period", 0);
+ /**
+ * The number of iothreads
+ * Data type: Integer.<br>
+ * Default value: <code>0</code>
Review Comment:
This says default is 0, but the line below (Java code) shows that we set it to 1 by default.
##########
agent/conf/agent.properties:
##########
@@ -295,3 +295,6 @@ iscsi.session.cleanup.enabled=false
# Enable/disable IO driver for Qemu (in case it is not set CloudStack can also detect if its supported by qemu)
# enable.io.uring=true
+
+# The number of iothreads. There should be only 1 or 2 IOThreads per host CPU (default is 1)
Review Comment:
Should we add a comment here that this is applied per VM and not per host?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1883,12 +1909,14 @@ public String toString() {
}
public static class SCSIDef {
+
Review Comment:
Empty line
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -761,6 +776,14 @@ public void setDeviceType(DeviceType deviceType) {
_deviceType = deviceType;
}
+ public boolean getIothreads() {
Review Comment:
This returns a boolean, but to me it implies a number which it will return.
Is this method even ever called?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -105,6 +106,7 @@ public String toString() {
private String _machine;
private String _nvram;
private String _nvramTemplate;
+ private String iothreads;
Review Comment:
Shouldn't this be a int and casted to a string only at the latest moment?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3185,12 +3199,32 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
- protected void setDiskIoDriver(DiskDef disk) {
- if (enableIoUring) {
+ public void setDiskIoDriver(DiskDef disk, boolean iothreadsEnabled, IoDriver ioDriver) {
+ if (iothreadsEnabled) {
+ disk.setIothreads(iothreadsEnabled);
+ if (!enableIoUring && IoDriver.IOURING == ioDriver) {
Review Comment:
Should we maybe remove this check for iouring? That this PR simply allows you to enable io_uring per VM/Storage pool? Remove the agent.properties setting.
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3185,12 +3199,32 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
- protected void setDiskIoDriver(DiskDef disk) {
- if (enableIoUring) {
+ public void setDiskIoDriver(DiskDef disk, boolean iothreadsEnabled, IoDriver ioDriver) {
+ if (iothreadsEnabled) {
+ disk.setIothreads(iothreadsEnabled);
+ if (!enableIoUring && IoDriver.IOURING == ioDriver) {
+ //setting io=threads as default
+ disk.setIoDriver(IoDriver.THREADS);
+ } else {
+ disk.setIoDriver(ioDriver);
+ }
+ } else if (enableIoUring) {
disk.setIoDriver(DiskDef.IoDriver.IOURING);
Review Comment:
Applies here as well. Try to make this uniform and have it work the same is iothreads now works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1382114777
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [13.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396786476
<b>Trillian test result (tid-5900)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43178 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6909-t5900-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 52.77 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 34.01 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 93.82 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396656086
@nvazquez @wido has either of you tested this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1400125335
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396182261
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
wido commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1384902598
>
Ok, great! This PR is very much welcome. Looking forward to the changes so I can do an additional review.
Ping @Rubueno and @BartJM to get them onboard as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1072088093
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3185,12 +3199,32 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
- protected void setDiskIoDriver(DiskDef disk) {
- if (enableIoUring) {
+ public void setDiskIoDriver(DiskDef disk, boolean iothreadsEnabled, IoDriver ioDriver) {
+ if (iothreadsEnabled) {
+ disk.setIothreads(iothreadsEnabled);
+ if (!enableIoUring && IoDriver.IOURING == ioDriver) {
Review Comment:
@wido, I think it's good to leave the check if the OS supports the `io_uring` option. I've just removed it from the `agent.properties` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291199
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [15.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
wido commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1363354604
Am I right that you can also set this on a per VM base using the VmDetails (Settings in the UI) rather then per storage pool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6909: KVM support of iothreads and IO driver policy
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1324644327
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [28.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1400140292
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1401109978
<b>Trillian test result (tid-5954)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41828 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6909-t5954-kvm-centos7.zip
Smoke tests completed. 103 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_09_project_suspend | `Error` | 1.08 | test_projects.py
test_10_project_activation | `Error` | 1.07 | test_projects.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
test_02_upgrade_kubernetes_cluster | `Failure` | 385.89 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 575.74 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1401545601
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by sonarcloud.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1399878878
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [15.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1386962286
@slavkap do you want this included in 4.18? And is there much more work on this?
tnx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1319821859
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [27.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396109276
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1073975173
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3055,24 +3073,34 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
- protected void setDiskIoDriver(DiskDef disk) {
- if (enableIoUring) {
- disk.setIoDriver(DiskDef.IoDriver.IOURING);
+ public void setDiskIoDriver(DiskDef disk, IoDriverPolicy ioDriver) {
+ s_logger.debug(String.format("Disk IO driver policy [%s]. The host supports the io_uring policy [%s]", ioDriver, enableIoUring));
+ if (ioDriver != null) {
+ if (IoDriverPolicy.IOURING != ioDriver) {
Review Comment:
discussed it offline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396181846
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385627335
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6909)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list) [15.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396840715
> @nvazquez @wido has either of you tested this?
It was code review sorry @DaanHoogland, let me test it this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6909: KVM support of iothreads and IO driver policy
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1403342160
<b>Trillian test result (tid-5992)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43444 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6909-t5992-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 1040.25 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org