You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/05 05:31:21 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #7231: bugfix: control validation handling and related state / queries

codecov-io edited a comment on issue #7231: bugfix: control validation handling and related state / queries
URL: https://github.com/apache/incubator-superset/pull/7231#issuecomment-480153368
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=h1) Report
   > Merging [#7231](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/e39b16994946b2a7975af3ed76245e77303329e2?src=pr&el=desc) will **increase** coverage by `8.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7231/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           lyftga    #7231      +/-   ##
   ==========================================
   + Coverage   64.49%   72.61%   +8.12%     
   ==========================================
     Files         425       78     -347     
     Lines       20879    10652   -10227     
     Branches     2280        0    -2280     
   ==========================================
   - Hits        13466     7735    -5731     
   + Misses       7287     2917    -4370     
   + Partials      126        0     -126
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/tasks/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvX19pbml0X18ucHk=) | `100% <0%> (ø)` | :arrow_up: |
   | [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | | |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
   | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | |
   | [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | | |
   | [superset/assets/src/query/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9pbmRleC50cw==) | | |
   | [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | | |
   | [...erset/assets/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9RdWVyeVNlYXJjaC5qc3g=) | | |
   | [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQW5ub3RhdGlvbkxheWVyLmpzeA==) | | |
   | [...assets/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDaGFydElkc0Zyb21MYXlvdXQuanM=) | | |
   | ... and [334 more](https://codecov.io/gh/apache/incubator-superset/pull/7231/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=footer). Last update [e39b169...84cc7b4](https://codecov.io/gh/apache/incubator-superset/pull/7231?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org