You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/08/14 01:33:00 UTC
[jira] [Comment Edited] (LUCENE-10002) Remove
IndexSearcher#search(Query,Collector) in favor of
IndexSearcher#search(Query,CollectorManager)
[ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399009#comment-17399009 ]
Greg Miller edited comment on LUCENE-10002 at 8/14/21, 1:32 AM:
----------------------------------------------------------------
Nice [~zacharymorn]! Quite a large change for sure! I took a look at the DrillSideways changes and they appear correct to me at first glance, but I'll see if I can spent more time going through the whole PR in the next couple of days.
In the meantime, I went ahead and spun off LUCENE-10050 to track making a similar API change to DrillSideways.
was (Author: gsmiller):
Nice [~zacharymorn]! Quite a large change for sure! I took a look at the DrillSideways changes and they appear correct to me at first glance, but I'll see if I can spent more time going through the whole PR in the next couple of days.
In the meantime, I went ahead and spun off LUCENE-10050 to track making a similar API change to DrillSidways.
> Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10002
> URL: https://issues.apache.org/jira/browse/LUCENE-10002
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but that it would always search on the caller thread when calling {{IndexSearcher#search(Query,Collector)}}.
> Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to return a {{CollectorManager}} instead of a {{Collector}}?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org