You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiangzhx (via GitHub)" <gi...@apache.org> on 2023/06/14 05:57:15 UTC
[GitHub] [arrow-datafusion] jiangzhx commented on a diff in pull request #6664: minor: use sql to setup test data for aggregate.slt rather than rust
jiangzhx commented on code in PR #6664:
URL: https://github.com/apache/arrow-datafusion/pull/6664#discussion_r1229024390
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -307,73 +357,73 @@ SELECT median(c12) FROM aggregate_test_100
# median_i8
query I
-SELECT median(a) FROM median_i8
+SELECT median(col_i8) FROM median_table
----
-14
# median_i16
query I
-SELECT median(a) FROM median_i16
+SELECT median(col_i16) FROM median_table
----
-16334
# median_i32
query I
-SELECT median(a) FROM median_i32
+SELECT median(col_i32) FROM median_table
----
-1073741774
# median_i64
query I
-SELECT median(a) FROM median_i64
+SELECT median(col_i64) FROM median_table
----
-4611686018427387854
# median_u8
query I
-SELECT median(a) FROM median_u8
+SELECT median(col_u8) FROM median_table
----
50
# median_u16
query I
-SELECT median(a) FROM median_u16
+SELECT median(col_u16) FROM median_table
----
50
# median_u32
query I
-SELECT median(a) FROM median_u32
+SELECT median(col_u32) FROM median_table
----
50
# median_u64
query I
-SELECT median(a) FROM median_u64
+SELECT median(col_u64) FROM median_table
----
50
# median_f32
query R
-SELECT median(a) FROM median_f32
+SELECT median(col_f32) FROM median_table
----
-3.3
+2.75
Review Comment:
Change `2.75` to `3.3`
Cause by testdata has been changed from
`1.1, 4.4, 5.5, 3.3, 2.2`
to
`1.1, 4.4, 3.3, 2.2`
It's makes it easier to create all the testdata in one table, because other testdata only have 4 column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org