You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andrés de la Peña (JIRA)" <ji...@apache.org> on 2017/06/13 09:22:00 UTC
[jira] [Updated] (CASSANDRA-13595) Short read protection doesn't
work at the end of a partition
[ https://issues.apache.org/jira/browse/CASSANDRA-13595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrés de la Peña updated CASSANDRA-13595:
------------------------------------------
Description:
It seems that short read protection doesn't work when the short read is done at the end of a partition. The final assertion of this dtest fails:
{code}
def short_read_partitions_delete_test(self):
cluster = self.cluster
cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
cluster.set_batch_commitlog(enabled=True)
cluster.populate(2).start(wait_other_notice=True)
node1, node2 = self.cluster.nodelist()
session = self.patient_cql_connection(node1)
create_ks(session, 'ks', 2)
session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
# we write 1 and 2 in a partition: all nodes get it.
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
# we delete partition 1: only node 1 gets it.
node2.flush()
node2.stop(wait_other_notice=True)
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 1"))
node2.start(wait_other_notice=True)
# we delete partition 2: only node 2 gets it.
node1.flush()
node1.stop(wait_other_notice=True)
session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
node1.start(wait_other_notice=True)
# read from both nodes
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
assert_none(session, "SELECT * FROM t LIMIT 1")
{code}
However, the dtest passes if we remove the {{LIMIT 1}}.
Here is a slight variation of the test with the same result:
{code}
def short_read_partitions_delete_test(self):
cluster = self.cluster
cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
cluster.set_batch_commitlog(enabled=True)
cluster.populate(2).start(wait_other_notice=True)
node1, node2 = self.cluster.nodelist()
session = self.patient_cql_connection(node1)
create_ks(session, 'ks', 2)
session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
# we write 1 and 2 in a partition: all nodes get it.
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 2)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
# we delete partition 1: only node 1 gets it.
node2.flush()
node2.stop(wait_other_notice=True)
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 1 AND c = 2"))
node2.start(wait_other_notice=True)
# we delete partition 2: only node 2 gets it.
node1.flush()
node1.stop(wait_other_notice=True)
session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
node1.start(wait_other_notice=True)
# read from both nodes
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
assert_one(session, "SELECT * FROM t LIMIT 2", [1, 1])
{code}
Short read protection [uses a {{SinglePartitionReadCommand}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/DataResolver.java#L484], maybe it should use a {{PartitionRangeReadCommand}} instead?
was:
It seems that short read protection doesn't work when the short read is done at the end of a partition. The final assertion of this dtest fails:
{code}
def short_read_partitions_delete_test(self):
cluster = self.cluster
cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
cluster.set_batch_commitlog(enabled=True)
cluster.populate(2).start(wait_other_notice=True)
node1, node2 = self.cluster.nodelist()
session = self.patient_cql_connection(node1)
create_ks(session, 'ks', 2)
session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
# we write 1 and 2 in a partition: all nodes get it.
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
# we delete partition 1: only node 1 gets it.
node2.flush()
node2.stop(wait_other_notice=True)
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 1"))
node2.start(wait_other_notice=True)
# we delete partition 2: only node 2 gets it.
node1.flush()
node1.stop(wait_other_notice=True)
session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
node1.start(wait_other_notice=True)
# read from both nodes
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
assert_none(session, "SELECT * FROM t LIMIT 1")
{code}
However, the dtest passes if we remove the {{LIMIT 1}}.
Here is a slight variation of the test with the same result:
{code}
def short_read_partitions_delete_test(self):
cluster = self.cluster
cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
cluster.set_batch_commitlog(enabled=True)
cluster.populate(2).start(wait_other_notice=True)
node1, node2 = self.cluster.nodelist()
session = self.patient_cql_connection(node1)
create_ks(session, 'ks', 2)
session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
# we write 1 and 2 in a partition: all nodes get it.
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 2)", consistency_level=ConsistencyLevel.ALL))
session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
# we delete partition 1: only node 1 gets it.
node2.flush()
node2.stop(wait_other_notice=True)
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 1 AND c = 2"))
node2.start(wait_other_notice=True)
# we delete partition 2: only node 2 gets it.
node1.flush()
node1.stop(wait_other_notice=True)
session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
node1.start(wait_other_notice=True)
# read from both nodes
session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
assert_one(session, "SELECT * FROM t LIMIT 2", [1, 1])
{code}
Short read protection uses a [{{SinglePartitionReadCommand}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/DataResolver.java#L484], maybe it should use a {{PartitionRangeReadCommand}} instead?
> Short read protection doesn't work at the end of a partition
> ------------------------------------------------------------
>
> Key: CASSANDRA-13595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13595
> Project: Cassandra
> Issue Type: Bug
> Components: Coordination
> Reporter: Andrés de la Peña
>
> It seems that short read protection doesn't work when the short read is done at the end of a partition. The final assertion of this dtest fails:
> {code}
> def short_read_partitions_delete_test(self):
> cluster = self.cluster
> cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
> cluster.set_batch_commitlog(enabled=True)
> cluster.populate(2).start(wait_other_notice=True)
> node1, node2 = self.cluster.nodelist()
> session = self.patient_cql_connection(node1)
> create_ks(session, 'ks', 2)
> session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
> # we write 1 and 2 in a partition: all nodes get it.
> session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
> session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
> # we delete partition 1: only node 1 gets it.
> node2.flush()
> node2.stop(wait_other_notice=True)
> session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
> session.execute(SimpleStatement("DELETE FROM t WHERE k = 1"))
> node2.start(wait_other_notice=True)
> # we delete partition 2: only node 2 gets it.
> node1.flush()
> node1.stop(wait_other_notice=True)
> session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
> session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
> node1.start(wait_other_notice=True)
> # read from both nodes
> session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
> assert_none(session, "SELECT * FROM t LIMIT 1")
> {code}
> However, the dtest passes if we remove the {{LIMIT 1}}.
> Here is a slight variation of the test with the same result:
> {code}
> def short_read_partitions_delete_test(self):
> cluster = self.cluster
> cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
> cluster.set_batch_commitlog(enabled=True)
> cluster.populate(2).start(wait_other_notice=True)
> node1, node2 = self.cluster.nodelist()
> session = self.patient_cql_connection(node1)
> create_ks(session, 'ks', 2)
> session.execute("CREATE TABLE t (k int, c int, PRIMARY KEY(k, c)) WITH read_repair_chance = 0.0")
> # we write 1 and 2 in a partition: all nodes get it.
> session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 1)", consistency_level=ConsistencyLevel.ALL))
> session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (1, 2)", consistency_level=ConsistencyLevel.ALL))
> session.execute(SimpleStatement("INSERT INTO t (k, c) VALUES (2, 1)", consistency_level=ConsistencyLevel.ALL))
> # we delete partition 1: only node 1 gets it.
> node2.flush()
> node2.stop(wait_other_notice=True)
> session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ONE)
> session.execute(SimpleStatement("DELETE FROM t WHERE k = 1 AND c = 2"))
> node2.start(wait_other_notice=True)
> # we delete partition 2: only node 2 gets it.
> node1.flush()
> node1.stop(wait_other_notice=True)
> session = self.patient_cql_connection(node2, 'ks', consistency_level=ConsistencyLevel.ONE)
> session.execute(SimpleStatement("DELETE FROM t WHERE k = 2"))
> node1.start(wait_other_notice=True)
> # read from both nodes
> session = self.patient_cql_connection(node1, 'ks', consistency_level=ConsistencyLevel.ALL)
> assert_one(session, "SELECT * FROM t LIMIT 2", [1, 1])
> {code}
> Short read protection [uses a {{SinglePartitionReadCommand}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/DataResolver.java#L484], maybe it should use a {{PartitionRangeReadCommand}} instead?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org