You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/03 15:07:51 UTC

[GitHub] [incubator-nuttx] AlanRosenthal opened a new pull request #5147: Improve dependencies for include/nuttx/version.h

AlanRosenthal opened a new pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147


   ## Summary
   `include/nuttx/version.h` is dependent on `.version`, which needs to run for every invocation of make, since git info can update at any time.
   Currently the `.version` target is PHONY, thus making `include/nuttx/version.h` and `context` targets (and every target that depends on `context`) have to run every time.
   
   ## Impact
   This PR modifies `.version` so it's a real rule. Additionally, `tools/version.sh` is run every invocation of make. This maintains the current behavior while preventing some targets from needlessly running every time
   
   ## Testing
   Verified `.version` changed appropriately when git's commit changed.
   Verified `include/nuttx/version.h` changed appropriately only when a new `.version` file was generated 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5147: Improve dependencies for include/nuttx/version.h

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004987626


   > > @AlanRosenthal sorry can you try to rebase again and drop the merge commit. Looks like there are still issues.
   > 
   > I tried resolving the conflict with github's web ui. looks like it's better to just use the good old fashioned CLI
   
   Github loves merge commits.  I personally don't use its Web UI at all. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #5147: Improve dependencies for include/nuttx/version.h

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5147: Improve dependencies for include/nuttx/version.h

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004611524


   @AlanRosenthal sorry can you try to rebase again and drop the merge commit.  Looks like there are still issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5147: Improve dependencies for include/nuttx/version.h

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004198193


   @AlanRosenthal please rebase, the other PR is now merged and caused this little conflict. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] AlanRosenthal commented on pull request #5147: Improve dependencies for include/nuttx/version.h

Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on pull request #5147:
URL: https://github.com/apache/incubator-nuttx/pull/5147#issuecomment-1004907868


   > @AlanRosenthal sorry can you try to rebase again and drop the merge commit. Looks like there are still issues.
   
   I tried resolving the conflict with github's web ui. looks like it's better to just use the good old fashioned CLI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org