You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by cestella <gi...@git.apache.org> on 2017/09/26 19:20:38 UTC
[GitHub] metron pull request #772: METRON-1209: Make stellar repl take logging proper...
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/772
METRON-1209: Make stellar repl take logging properties, like other CLI apps in metron
## Contributor Comments
Right now we don't have an ability to specify the logging settings. We should make the REPL work just like the flat file loader or the MaaS CLI.
A note about the new maven project, this is just a place to keep the 3rd party extension we use in the unit tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron sideloading_bugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #772
----
commit 5355e4c8443911103ee2e6430f181cb35a8b5863
Author: cstella <ce...@gmail.com>
Date: 2017-09-26T19:16:01Z
METRON-1209: Make stellar repl take logging properties, like other CLI apps in metron
----
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/772
As a note :
```bash
-> % mvn exec:java \
-Dexec.mainClass="org.apache.metron.stellar.common.shell.StellarShell" -Dexec.args="-l src/test/resources/log4j.properties"
```
Is how to run this with mv:exec from the stellar-common directory.
I also changed the log4j.properties to DEBUG from error.
---
[GitHub] metron pull request #772: METRON-1209: Make stellar repl take logging proper...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/772
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/772
This looks good, how should it be tested?
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/772
Oh, sorry, forgot to respond here @ottobackwards You can test it by passing in a log4j properties (let's say something that turns on DEBUG logging) file via -l and ensure that the REPL shows debug logging.
Perhaps something like:
```
log4j.rootLogger=DEBUG,stdout
log4j.threshhold=ALL
log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
log4j.appender.stdout.layout.ConversionPattern=%d{ISO8601} %-5p [%t] %c{2} (%F:%M(%L)) - %m%n
log4j.appender.stdout.filter.1=org.apache.log4j.varia.StringMatchFilter
log4j.appender.stdout.filter.1.StringToMatch=ExpiredTokenRemover
log4j.appender.stdout.filter.1.AcceptOnMatch=false
log4j.appender.stdout.filter.2=org.apache.log4j.varia.StringMatchFilter
log4j.appender.stdout.filter.2.StringToMatch=interrupted
log4j.appender.stdout.filter.2.AcceptOnMatch=false
```
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/772
+1
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/772
It does not and should not. If that's what you're seeing, @nickwallen then it's a bug and I should fix it.
---
[GitHub] metron issue #772: METRON-1209: Make stellar repl take logging properties, l...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/772
Does this change the default log level of the REPL when run in a deployed Metron cluster?
---