You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/11/21 14:24:48 UTC
[GitHub] [commons-daemon] garydgregory commented on a change in pull request
#13: [DAEMON-414] prunsrv uses its log is before it is initialized.
garydgregory commented on a change in pull request #13: [DAEMON-414] prunsrv uses its log is before it is initialized.
URL: https://github.com/apache/commons-daemon/pull/13#discussion_r349112565
##########
File path: src/native/windows/apps/prunsrv/prunsrv.c
##########
@@ -1742,7 +1742,12 @@ void __cdecl main(int argc, char **argv)
/* Create the main Pool */
gPool = apxPoolCreate(NULL, 0);
- /* Parse the command line */
+ apxLogOpen(gPool, SO_LOGPATH, SO_LOGPREFIX, SO_LOGROTATE);
+ apxLogLevelSetW(NULL, SO_LOGLEVEL);
+ apxLogWrite(APXLOG_MARK_DEBUG "Apache Commons Daemon procrun (%s %d-bit) logging initialized.",
+ PRG_VERSION, PRG_BITS);
+
+ /* Parse the command line */
if ((lpCmdline = apxCmdlineParse(gPool, _options, _commands, _altcmds)) == NULL) {
Review comment:
Weird, I did a cut and paste. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services