You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/09/12 16:46:46 UTC
Review Request 25583: Alerts: add metric- and script-based alert types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25583/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-7282
https://issues.apache.org/jira/browse/AMBARI-7282
Repository: ambari
Description
-------
Added metric and script alerts. Also added saving the latest text from a given alerts
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py e987dae
ambari-agent/src/main/python/ambari_agent/Controller.py 0ceeeff
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py adb872a
ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6674fdf
ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 4894b62
ambari-agent/src/test/python/ambari_agent/dummy_files/test_script.py PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 639a02f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java 438d471
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 8bdd2ba
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/AlertDataManager.java 4670d3b
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 7f863a7
Diff: https://reviews.apache.org/r/25583/diff/
Testing
-------
[INFO] Ambari Main ....................................... SUCCESS [2.467s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.266s]
[INFO] Ambari Web ........................................ SUCCESS [13.644s]
[INFO] Ambari Views ...................................... SUCCESS [4.827s]
[INFO] Ambari Admin View ................................. SUCCESS [10.279s]
[INFO] Ambari Server ..................................... SUCCESS [26:04.212s]
[INFO] Ambari Agent ...................................... SUCCESS [8.333s]
[INFO] Ambari Client ..................................... SUCCESS [0.031s]
[INFO] Ambari Python Client .............................. SUCCESS [0.488s]
[INFO] Ambari Groovy Client .............................. SUCCESS [13.366s]
[INFO] Ambari Shell ...................................... SUCCESS [0.038s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.063s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.271s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:05.953s
[INFO] Finished at: Fri Sep 12 10:22:01 EDT 2014
[INFO] Final Memory: 39M/196M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 25583: Alerts: add metric- and script-based alert
types
Posted by Nate Cole <nc...@hortonworks.com>.
> On Sept. 12, 2014, 11:13 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py, line 218
> > <https://reviews.apache.org/r/25583/diff/1/?file=687674#file687674line218>
> >
> > Will this eventually use the same level as the rest of the agent?
Thanks for reviewing! Yes, logger is set using ambari-agent.ini
> On Sept. 12, 2014, 11:13 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py, line 53
> > <https://reviews.apache.org/r/25583/diff/1/?file=687677#file687677line53>
> >
> > Why not just throw an exception when there's no port that can be extracted? Isn't a port always required for a metric check?
If the metric is ganglia-based, that will likely be fetched as http://ganglia-host/ganglia/HDPService. Wasn't sure how to handle that so I just left as-is. (And, we aren't supplying a default_port like we did with port checks).
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25583/#review53177
-----------------------------------------------------------
On Sept. 12, 2014, 10:46 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25583/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 10:46 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7282
> https://issues.apache.org/jira/browse/AMBARI-7282
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added metric and script alerts. Also added saving the latest text from a given alerts
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py e987dae
> ambari-agent/src/main/python/ambari_agent/Controller.py 0ceeeff
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py adb872a
> ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6674fdf
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 4894b62
> ambari-agent/src/test/python/ambari_agent/dummy_files/test_script.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 639a02f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java 438d471
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 8bdd2ba
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/AlertDataManager.java 4670d3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 7f863a7
>
> Diff: https://reviews.apache.org/r/25583/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Main ....................................... SUCCESS [2.467s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.266s]
> [INFO] Ambari Web ........................................ SUCCESS [13.644s]
> [INFO] Ambari Views ...................................... SUCCESS [4.827s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.279s]
> [INFO] Ambari Server ..................................... SUCCESS [26:04.212s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.333s]
> [INFO] Ambari Client ..................................... SUCCESS [0.031s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.488s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.366s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.063s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.271s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:05.953s
> [INFO] Finished at: Fri Sep 12 10:22:01 EDT 2014
> [INFO] Final Memory: 39M/196M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 25583: Alerts: add metric- and script-based alert
types
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25583/#review53177
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py
<https://reviews.apache.org/r/25583/#comment92638>
Will this eventually use the same level as the rest of the agent?
ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py
<https://reviews.apache.org/r/25583/#comment92639>
Why not just throw an exception when there's no port that can be extracted? Isn't a port always required for a metric check?
- Jonathan Hurley
On Sept. 12, 2014, 10:46 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25583/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 10:46 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7282
> https://issues.apache.org/jira/browse/AMBARI-7282
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added metric and script alerts. Also added saving the latest text from a given alerts
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py e987dae
> ambari-agent/src/main/python/ambari_agent/Controller.py 0ceeeff
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py adb872a
> ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6674fdf
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 4894b62
> ambari-agent/src/test/python/ambari_agent/dummy_files/test_script.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 639a02f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java 438d471
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 8bdd2ba
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/AlertDataManager.java 4670d3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 7f863a7
>
> Diff: https://reviews.apache.org/r/25583/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Main ....................................... SUCCESS [2.467s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.266s]
> [INFO] Ambari Web ........................................ SUCCESS [13.644s]
> [INFO] Ambari Views ...................................... SUCCESS [4.827s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.279s]
> [INFO] Ambari Server ..................................... SUCCESS [26:04.212s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.333s]
> [INFO] Ambari Client ..................................... SUCCESS [0.031s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.488s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.366s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.063s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.271s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:05.953s
> [INFO] Finished at: Fri Sep 12 10:22:01 EDT 2014
> [INFO] Final Memory: 39M/196M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 25583: Alerts: add metric- and script-based alert
types
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25583/#review53179
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 12, 2014, 10:46 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25583/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 10:46 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7282
> https://issues.apache.org/jira/browse/AMBARI-7282
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added metric and script alerts. Also added saving the latest text from a given alerts
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py e987dae
> ambari-agent/src/main/python/ambari_agent/Controller.py 0ceeeff
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py adb872a
> ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6674fdf
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json 4894b62
> ambari-agent/src/test/python/ambari_agent/dummy_files/test_script.py PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 639a02f
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertSummaryPropertyProvider.java 438d471
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java 8bdd2ba
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/AlertDataManager.java 4670d3b
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json 7f863a7
>
> Diff: https://reviews.apache.org/r/25583/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Main ....................................... SUCCESS [2.467s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.266s]
> [INFO] Ambari Web ........................................ SUCCESS [13.644s]
> [INFO] Ambari Views ...................................... SUCCESS [4.827s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.279s]
> [INFO] Ambari Server ..................................... SUCCESS [26:04.212s]
> [INFO] Ambari Agent ...................................... SUCCESS [8.333s]
> [INFO] Ambari Client ..................................... SUCCESS [0.031s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.488s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.366s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.063s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [7.271s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:05.953s
> [INFO] Finished at: Fri Sep 12 10:22:01 EDT 2014
> [INFO] Final Memory: 39M/196M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>