[jira] [Comment Edited] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027290#comment-16027290 ] 

Deepak Dixit edited comment on OFBIZ-9381 at 5/27/17 6:56 AM:
--------------------------------------------------------------

Hi Nicoals,

I reviewed it and it looks good to me, some minor improvement can be done:
- I think we can use entity-auto for updateRateAmount/deleteRateAmount service, they are belongs to CRUD operation
- Instead of Debug.log we can use Debug.logVerbose to print the newEntity.toMapString()
- We can use different log methods to print log in groovy scripts define in GroovyBaseScript, if needed we can add logVerbose as well. 
- I think we can change delete to expire in separate commit
- We can use default-value attribute for setting the default value for service in parameter.



was (Author: deepak.dixit):
Hi Nicoals,

I reviewed it and it looks good to me, some minor improvement can be done:
- I think we can use entity-auto for updateRateAmount/deleteRateAmount service, they are belongs to CRUD operation
- Instead of Debug.log we can use Debug.logVerbose to print the newEntity.toMapString()
- I think we can change delete to expire in separate commit
- We can use default-value attribute for setting the default value for service in parameter.


> Convert RateServices.xml mini-lang to groovyDSL
> -----------------------------------------------
>
>                 Key: OFBIZ-9381
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9381
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>              Labels: groovy, mini-lang
>         Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some mini-lang service to groovy script.
> I converted updateRateAmount, deleteRateAmount, updatePartyRate and deleteRateAmount.
> Delete isn't a good definition for the service who expire the element instead of remove if. So I propose with the patch to move the deleteRateAmount and deletePartyRate to expireRateAmount and expirePartyRate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)