[jira] [Resolved] (SSHD-202) SSH Client silently accepts server key by default :-(

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SSHD-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved SSHD-202.
----------------------------------

    Resolution: Fixed

https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=commit;h=5019e0052628b3b92ec426070471ca19efe55827
                
> SSH Client silently accepts server key by default :-(
> -----------------------------------------------------
>
>                 Key: SSHD-202
>                 URL: https://issues.apache.org/jira/browse/SSHD-202
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>         Environment: Windows
>            Reporter: Andrew C
>            Assignee: Guillaume Nodet
>             Fix For: 0.9.0
>
>         Attachments: sshd-202.patch
>
>
> The default SshClient, returned by SshClient.setUpDefaultClient, silently accepts the server's public key.  This is because ClientSessionImpl.checkHost allows a null ServerKeyVerifier and silently succeeds,  This is, IMNSHO, really bad.  Instead, I'd suggest:
> - SshClient.checkConfig require a ServerKeyVerifier
> - ClientSessionImpl.checkHost crash and burn when ServerKeyVerifier is null
> - SshClient.setupDefaultClient set it to AcceptAllServerKeyVerifier (maintains compatibility)
> - and AcceptAllServerKeyVerifier clearly log its action at the warning, not trace level
> Tweaking RequiredServerKeyVerifier to log its actions would also be helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira