You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ta...@apache.org on 2017/06/17 03:06:07 UTC

[1/2] beam git commit: Remove UnsupportedOperationVisitor, which is currently just a no-op

Repository: beam
Updated Branches:
  refs/heads/DSL_SQL 738eb4dd0 -> 887cf3a1a


Remove UnsupportedOperationVisitor, which is currently just a no-op


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/98383b6f
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/98383b6f
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/98383b6f

Branch: refs/heads/DSL_SQL
Commit: 98383b6faa931bcf2df6c16f1098953723f83a28
Parents: 738eb4d
Author: Tyler Akidau <ta...@apache.org>
Authored: Fri Jun 16 16:16:46 2017 -0700
Committer: Tyler Akidau <ta...@apache.org>
Committed: Fri Jun 16 20:04:22 2017 -0700

----------------------------------------------------------------------
 .../beam/dsls/sql/planner/BeamQueryPlanner.java |  4 +--
 .../planner/UnsupportedOperatorsVisitor.java    | 28 --------------------
 2 files changed, 1 insertion(+), 31 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/98383b6f/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/BeamQueryPlanner.java
----------------------------------------------------------------------
diff --git a/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/BeamQueryPlanner.java b/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/BeamQueryPlanner.java
index ef71b53..2eaf9e7 100644
--- a/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/BeamQueryPlanner.java
+++ b/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/BeamQueryPlanner.java
@@ -152,9 +152,7 @@ public class BeamQueryPlanner {
   }
 
   private SqlNode validateNode(SqlNode sqlNode) throws ValidationException {
-    SqlNode validatedSqlNode = planner.validate(sqlNode);
-    validatedSqlNode.accept(new UnsupportedOperatorsVisitor());
-    return validatedSqlNode;
+    return planner.validate(sqlNode);
   }
 
   public Map<String, BaseBeamTable> getSourceTables() {

http://git-wip-us.apache.org/repos/asf/beam/blob/98383b6f/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/UnsupportedOperatorsVisitor.java
----------------------------------------------------------------------
diff --git a/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/UnsupportedOperatorsVisitor.java b/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/UnsupportedOperatorsVisitor.java
deleted file mode 100644
index 4a71024..0000000
--- a/dsls/sql/src/main/java/org/apache/beam/dsls/sql/planner/UnsupportedOperatorsVisitor.java
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.beam.dsls.sql.planner;
-
-import org.apache.calcite.sql.util.SqlShuttle;
-
-/**
- * Unsupported operation to visit a RelNode.
- *
- */
-class UnsupportedOperatorsVisitor extends SqlShuttle {
-
-}


[2/2] beam git commit: [BEAM-2459] This closes #3384

Posted by ta...@apache.org.
[BEAM-2459] This closes #3384


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/887cf3a1
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/887cf3a1
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/887cf3a1

Branch: refs/heads/DSL_SQL
Commit: 887cf3a1a3bf6357bbb8efde519d470634ee6ea2
Parents: 738eb4d 98383b6
Author: Tyler Akidau <ta...@apache.org>
Authored: Fri Jun 16 20:05:02 2017 -0700
Committer: Tyler Akidau <ta...@apache.org>
Committed: Fri Jun 16 20:05:02 2017 -0700

----------------------------------------------------------------------
 .../beam/dsls/sql/planner/BeamQueryPlanner.java |  4 +--
 .../planner/UnsupportedOperatorsVisitor.java    | 28 --------------------
 2 files changed, 1 insertion(+), 31 deletions(-)
----------------------------------------------------------------------