You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/28 11:23:34 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
yuruguo opened a new pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828
### Motivation
Fixes #11827
Option `--subscriber-name` is redundant and easy to cause interference when the size of `--subscriptions` is equal to 1 but `--num-subscriptions` is not equal to 1 in command `bin/pulsar-perf consume`.
### Modifications
- Marked as deprecated and hide option `--subscriber-name`
- Replace `--subscriber-name` with `--subscriptions first element`
- Modify the corresponding doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908823973
Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] hide option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-913825775
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908823973
Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908842170
> Thanks for your contribution. Does this affect only master or other versioned docs?
> If latter, could you please help update all affected versions? Thanks
This only affects maser and the version that will be released later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908027781
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-907614598
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-913463785
I believe that you can "hide" the parameter
but you have to let the users use the old syntax (with -s)
I am not sure if it is worth.
Using "-s" is quite convenient especially when you are running very simple smoke tests.
what about deprecating "-ss" and let "-s" behave like "-ss" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908061873
If there is no problem, can you merge it? @eolivelli @hangc0276 @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-907995132
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908061873
PTAL @eolivelli @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-907746391
PTAL and approve `workflows awaiting approval`？ @eolivelli @hangc0276 @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-907614598
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #11828: [testclient] hide option -s and substitute -ss(0) for it
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908027781
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-913461944
> it looks like we are not handling compatibility.
> with this change the 'subscriberName' parameter is ignored.
> that is worse than letting the user see an error.
>
> IMHO we should support the old parameter, it is only a matter of handling it as one single value in subscriptions or something like that
So we don’t need to make any changes? If this is the case I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #11828: [testclient] hide option -s and substitute -ss(0) for it
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-913578123
> I believe that you can "hide" the parameter
> but you have to let the users use the old syntax (with -s)
>
> I am not sure if it is worth.
> Using "-s" is quite convenient especially when you are running very simple smoke tests.
>
> what about deprecating "-ss" and let "-s" behave like "-ss" ?
Thanks for your suggestion, I think perhaps the following is a way to consider:
Keep parameter `-s`(no default value) and make it work, but its priority is higher than parameter `-ss` only when `-s` is not null(that is, the user specifies `-s`).
_related to code1_
_related to code2_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-908842170
> Thanks for your contribution. Does this affect only master or other versioned docs?
> If latter, could you please help update all affected versions? Thanks
This only affects maser and the version that will be released later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #11828: [testclient] deprecate option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-907995132
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #11828: [testclient] hide option --subscriber-name and substitute --subscriptions first element for it
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #11828:
URL: https://github.com/apache/pulsar/pull/11828#issuecomment-913825775
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org