You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/10/10 01:02:47 UTC
Review Request 26531: Defining schema for the heartbeat RPC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Bugs: AURORA-690
https://issues.apache.org/jira/browse/AURORA-690
Repository: aurora
Description
-------
Defining the flag and the schema for the update coordination (aka heartbeats).
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
Diff: https://reviews.apache.org/r/26531/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 10, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 816
> > <https://reviews.apache.org/r/26531/diff/2/?file=717152#file717152line816>
> >
> > This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]? (JobUpdateStatus has a much wider set of values of which only ERROR is included)
>
> Maxim Khutornenko wrote:
> Yeah, this is temporarily on hold until we get @dev consensus.
Mind discarding this review for now to get it off our radar? You can click reopen on it once it's ready for review again.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56206
-----------------------------------------------------------
On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 10, 2014, 8:19 p.m., Joshua Cohen wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 816
> > <https://reviews.apache.org/r/26531/diff/2/?file=717152#file717152line816>
> >
> > This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]? (JobUpdateStatus has a much wider set of values of which only ERROR is included)
Yeah, this is temporarily on hold until we get @dev consensus.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56206
-----------------------------------------------------------
On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56206
-----------------------------------------------------------
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment96529>
This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]? (JobUpdateStatus has a much wider set of values of which only ERROR is included)
- Joshua Cohen
On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 20, 2014, 8 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 109
> > <https://reviews.apache.org/r/26531/diff/3/?file=723030#file723030line109>
> >
> > Other instances of delays stored in ms seem to be INT not BIGINT. Signed BIGINT is something on the order of 300,000 millenia between heartbeats? ;).
Good point, it's actually i32 in the schema anyway.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57415
-----------------------------------------------------------
On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:44 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Kevin Sweeney <ke...@apache.org>.
On Mon, Oct 20, 2014 at 1:00 PM, Joshua Cohen <jc...@twopensource.com>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/#review57415
> -----------------------------------------------------------
>
>
> I know I brought this up in the design discussion, so maybe this is just
> my naïveté of the internal workings of the thrift API, but where (if
> anywhere) does auth come into play here?
>
> The presence of a SessionKey argument in the RPC makes the client send
authenticated requests.
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
> <https://reviews.apache.org/r/26531/#comment98115>
>
> Other instances of delays stored in ms seem to be INT not BIGINT.
> Signed BIGINT is something on the order of 300,000 millenia between
> heartbeats? ;).
>
>
> - Joshua Cohen
>
>
> On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/26531/
> > -----------------------------------------------------------
> >
> > (Updated Oct. 16, 2014, 4:44 p.m.)
> >
> >
> > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill
> Farner.
> >
> >
> > Bugs: AURORA-690
> > https://issues.apache.org/jira/browse/AURORA-690
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > -------
> >
> > Defining the flag and the schema for the update coordination (aka
> heartbeats).
> >
> >
> > Diffs
> > -----
> >
> >
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> >
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
> 77032d84f91b149c01ce4ac62da7ca331a2b6445
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
> db6a8719d18fee720f74ebcd2079ad36201cc831
> > src/main/thrift/org/apache/aurora/gen/api.thrift
> 8794731f4b3f1033588bdfa33c292e4796319a2a
> >
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
> 3871dae68fcdc6402cb61a7244b46114617eecff
> >
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java
> 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> > src/test/python/apache/aurora/client/api/test_scheduler_client.py
> d78e7dca28d67997bc6c98cff619ab94a257c7dc
> >
> > Diff: https://reviews.apache.org/r/26531/diff/
> >
> >
> > Testing
> > -------
> >
> > ./gradlew -Pq build
> >
> >
> > Thanks,
> >
> > Maxim Khutornenko
> >
> >
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57415
-----------------------------------------------------------
I know I brought this up in the design discussion, so maybe this is just my naïveté of the internal workings of the thrift API, but where (if anywhere) does auth come into play here?
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
<https://reviews.apache.org/r/26531/#comment98115>
Other instances of delays stored in ms seem to be INT not BIGINT. Signed BIGINT is something on the order of 300,000 millenia between heartbeats? ;).
- Joshua Cohen
On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:44 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57911
-----------------------------------------------------------
Ship it!
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment98806>
-1 indent
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment98816>
Mind adding a note about what happens when an unknown job update is referenced?
- Bill Farner
On Oct. 21, 2014, 5:58 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 5:58 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 401083621e1a1bbe43751b8bd168277543b9a812
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 076008e400bd9200cfd70fc469a4c310f291d70f
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 5:58 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-690
https://issues.apache.org/jira/browse/AURORA-690
Repository: aurora
Description
-------
Defining the flag and the schema for the update coordination (aka heartbeats).
Diffs (updated)
-----
build.gradle f4352d2ebf858930a6f219d96519e1cdc2bc14e5
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java e792d23d6bb13b4e61b078beea6d063f72f0d8fc
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
src/main/thrift/org/apache/aurora/gen/api.thrift 401083621e1a1bbe43751b8bd168277543b9a812
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
src/test/python/apache/aurora/client/api/test_scheduler_client.py 076008e400bd9200cfd70fc469a4c310f291d70f
Diff: https://reviews.apache.org/r/26531/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 20, 2014, 7:35 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 1024
> > <https://reviews.apache.org/r/26531/diff/3/?file=723031#file723031line1024>
> >
> > This method name reads strangely to me, since it's using "heartbeat" as a verb. 'Pulse' has a similar meaning, and can be used as both a verb and a noun. What do you think?
Sure, works for me.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57410
-----------------------------------------------------------
On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:44 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review57410
-----------------------------------------------------------
Paused at the RPC name, since the rest of the change is mechanical, and the method name could have a large ripple.
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment98109>
This method name reads strangely to me, since it's using "heartbeat" as a verb. 'Pulse' has a similar meaning, and can be used as both a verb and a noun. What do you think?
- Bill Farner
On Oct. 16, 2014, 4:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:44 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 4:44 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Changes
-------
Updating to match proposed design approach.
Bugs: AURORA-690
https://issues.apache.org/jira/browse/AURORA-690
Repository: aurora
Description
-------
Defining the flag and the schema for the update coordination (aka heartbeats).
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
Diff: https://reviews.apache.org/r/26531/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 4:42 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Bugs: AURORA-690
https://issues.apache.org/jira/browse/AURORA-690
Repository: aurora
Description
-------
Defining the flag and the schema for the update coordination (aka heartbeats).
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
Diff: https://reviews.apache.org/r/26531/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56083
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
-----------------------------------------------------------
(Updated Oct. 9, 2014, 11:23 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Changes
-------
Adding SessionKey into the heartbeat RPC and adding python test.
Bugs: AURORA-690
https://issues.apache.org/jira/browse/AURORA-690
Repository: aurora
Description
-------
Defining the flag and the schema for the update coordination (aka heartbeats).
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
Diff: https://reviews.apache.org/r/26531/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Oct. 9, 2014, 11:20 p.m., David McLaughlin wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 619
> > <https://reviews.apache.org/r/26531/diff/1/?file=717117#file717117line619>
> >
> > I think we decided not to do auto-resume once a job is paused due to lack of heartbeat, but I can't remember why. Maybe someone else remembers?
I don't quite see a difference between user pausing/resuming an update or the HB service doing so. Differentiating between the two would require a pause reason stored somewhere. I'd rather avoid extra complexity unless absolutely necessary.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56080
-----------------------------------------------------------
On Oct. 9, 2014, 11:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:23 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py d78e7dca28d67997bc6c98cff619ab94a257c7dc
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 26531: Defining schema for the heartbeat RPC.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56080
-----------------------------------------------------------
Ship it!
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment96435>
s/at/within/
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/26531/#comment96436>
I think we decided not to do auto-resume once a job is paused due to lack of heartbeat, but I can't remember why. Maybe someone else remembers?
- David McLaughlin
On Oct. 9, 2014, 11:02 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26531/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 11:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
>
>
> Bugs: AURORA-690
> https://issues.apache.org/jira/browse/AURORA-690
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Defining the flag and the schema for the update coordination (aka heartbeats).
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 137f97d33decd14bf2f6dcdd9cd18c3db2b7c89c
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 77032d84f91b149c01ce4ac62da7ca331a2b6445
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql db6a8719d18fee720f74ebcd2079ad36201cc831
> src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 93f79d7cfed2ba3d56548b43b926ce7ddec16c9e
>
> Diff: https://reviews.apache.org/r/26531/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>