You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/13 06:16:32 UTC

[GitHub] [flink] wuchong commented on pull request #13339: [FLINK-19157][jdbc] Added Phoenix dialect

wuchong commented on pull request #13339:
URL: https://github.com/apache/flink/pull/13339#issuecomment-707515140


   Thanks for the contribution and sorry for the late reply. 
   
   I think it's nice to support more JDBC dialect. However, I think we need to come up with a mechinism to test them. Currently, only MySQL, Postgres, and Derby dialects are supported, because they provide embedded server for testing. If we have  proper tests for the Phoenix dialect, I'm glad to review and merge it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org