You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/12/10 12:31:35 UTC
svn commit: r1817708 -
/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
Author: jleroux
Date: Sun Dec 10 12:31:35 2017
New Revision: 1817708
URL: http://svn.apache.org/viewvc?rev=1817708&view=rev
Log:
No functional changes, removes a bunch of useless fileOut.close() inside
try-with-resources blocks. FileOutputStream implements the Closeable interface,
which extends AutoCloseable
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
Modified: ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java?rev=1817708&r1=1817707&r2=1817708&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java Sun Dec 10 12:31:35 2017
@@ -632,11 +632,9 @@ public class UpsServices {
if (shipmentUpsSaveCertificationInfo) {
String outFileName = shipmentUpsSaveCertificationPath + "/UpsShipmentConfirmRequest" + shipmentId + "_" + shipmentRouteSegment.getString("shipmentRouteSegmentId") + ".xml";
- try {
- FileOutputStream fileOut = new FileOutputStream(outFileName);
+ try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(xmlString.toString().getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -653,11 +651,9 @@ public class UpsServices {
if (shipmentUpsSaveCertificationInfo) {
String outFileName = shipmentUpsSaveCertificationPath + "/UpsShipmentConfirmResponse" + shipmentId + "_" + shipmentRouteSegment.getString("shipmentRouteSegmentId") + ".xml";
- try {
- FileOutputStream fileOut = new FileOutputStream(outFileName);
+ try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(shipmentConfirmResponseString.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -912,7 +908,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(xmlString.toString().getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -932,7 +927,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(shipmentAcceptResponseString.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -1126,7 +1120,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(labelImageBytes);
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS LabelImage GIF file: [[[" + packageLabelGraphicImageString + "]]] to file: " + outFileName, module);
}
@@ -1136,7 +1129,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(labelInternationalSignatureGraphicImageBytes);
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS IntlSign LabelImage GIF file: [[[" + packageLabelInternationalSignatureGraphicImageString + "]]] to file: " + outFileName, module);
}
@@ -1146,7 +1138,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(packageLabelHTMLImageStringDecoded.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS LabelImage HTML file: [[[" + packageLabelHTMLImageStringDecoded + "]]] to file: " + outFileName, module);
}
@@ -1178,7 +1169,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(fileStringDecoded.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS High Value Report data: [[[" + fileStringDecoded + "]]] to file: " + outFileName, module);
}
@@ -1300,7 +1290,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(xmlString.toString().getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -1320,7 +1309,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(voidShipmentResponseString.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -1498,7 +1486,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(xmlString.toString().getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -1518,7 +1505,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(trackResponseString.getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}
@@ -2649,7 +2635,6 @@ public class UpsServices {
try (FileOutputStream fileOut = new FileOutputStream(outFileName)) {
fileOut.write(xmlString.toString().getBytes(UtilIO.getUtf8()));
fileOut.flush();
- fileOut.close();
} catch (IOException e) {
Debug.logInfo(e, "Could not save UPS XML file: [[[" + xmlString.toString() + "]]] to file: " + outFileName, module);
}