You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:42:31 UTC
[GitHub] [kafka] mjsax opened a new pull request #10048: MINOR: add docs for KIP-680
mjsax opened a new pull request #10048:
URL: https://github.com/apache/kafka/pull/10048
Call for review @bbejeck.
Follow up PR to #9660 for 2.8.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570698397
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
Review comment:
```suggestion
To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JimGalasyn commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
JimGalasyn commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570687710
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
Review comment:
```suggestion
To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570698424
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
+ required to pass in a <code>Properties</code> parameter. If <code>Properties</code> are passed
Review comment:
```suggestion
to the <code>TopologyTestDriver</code> class. If <code>Properties</code> are passed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JimGalasyn commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
JimGalasyn commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570687710
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
Review comment:
```suggestion
To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
```
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
+ required to pass in a <code>Properties</code> parameter. Furthermore, even if <code>Properties</code> are passed
Review comment:
```suggestion
If <code>Properties</code> are passed
```
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
+ required to pass in a <code>Properties</code> parameter. Furthermore, even if <code>Properties</code> are passed
Review comment:
```suggestion
required to pass in a <code>Properties</code> parameter. If <code>Properties</code> are passed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JimGalasyn commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
JimGalasyn commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570687920
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
+ required to pass in a <code>Properties</code> parameter. Furthermore, even if <code>Properties</code> are passed
Review comment:
```suggestion
required to pass in a <code>Properties</code> parameter. If <code>Properties</code> are passed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JimGalasyn commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
JimGalasyn commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570687920
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors are added to <code>TopologyTestDriver</code> class, that both don't
+ required to pass in a <code>Properties</code> parameter. Furthermore, even if <code>Properties</code> are passed
Review comment:
```suggestion
If <code>Properties</code> are passed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #10048:
URL: https://github.com/apache/kafka/pull/10048#discussion_r570698397
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
Review comment:
```suggestion
To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added
```
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -121,6 +121,12 @@ <h3><a id="streams_api_changes_280" href="#streams_api_changes_280">Streams API
the constructor, such as when using the console consumer. <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size">KIP-659</a>
has more details.
</p>
+ <p>
+ To simplify testing, two new constructors that don't require a <code>Properties</code> parameter have been added to the <code>TopologyTestDriver</code> class.
+ required to pass in a <code>Properties</code> parameter. If <code>Properties</code> are passed
Review comment:
```suggestion
to the <code>TopologyTestDriver</code> class. If <code>Properties</code> are passed
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #10048:
URL: https://github.com/apache/kafka/pull/10048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #10048: MINOR: add docs for KIP-680
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #10048:
URL: https://github.com/apache/kafka/pull/10048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org