You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/05/03 21:38:00 UTC
[jira] [Commented] (GEODE-2709) modify backward-compatibility
support to work better with geode
[ https://issues.apache.org/jira/browse/GEODE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463096#comment-16463096 ]
ASF subversion and git services commented on GEODE-2709:
--------------------------------------------------------
Commit 5be4e1f66d145af81d44c67c499f10cfd7d8f747 in geode's branch refs/heads/feature/GEODE-2709 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5be4e1f ]
GEODE-2709: modify backward-compatibility support to work better with geode
Removed the "product name" from toDataPre/fromDataPre methods and from
sanctionedDataSerializable.txt files.
> modify backward-compatibility support to work better with geode
> ---------------------------------------------------------------
>
> Key: GEODE-2709
> URL: https://issues.apache.org/jira/browse/GEODE-2709
> Project: Geode
> Issue Type: Improvement
> Components: serialization
> Reporter: Bruce Schuchardt
> Priority: Major
>
> Backward-compatibility support currently pays attention to a version's Product name and its compareTo method pays attention to the major/minor/etc numerals. This is an artifact of the GemFireXD effort at Pivotal a few years ago and should be removed. The Product name is no longer needed at all and compareTo should just compare the version ordinals.
> All places that compare versions should be scrutinized to make sure this change doesn't break anything.
> All methods with names beginning with toDataPre_ or fromDataPre_ need to be changed to remove the product name and the sanctionedDataSerializables.txt database needs to be updated to have these new method names and fingerprints (generated by the AnalyzeSerializablesJUnitTest).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)