You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2017/04/18 18:00:43 UTC
[jira] [Resolved] (BOOKKEEPER-1039) bk-merge-pr.py ask to run
findbugs and rat before merge
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo resolved BOOKKEEPER-1039.
-----------------------------------
Resolution: Fixed
Issue resolved by merging pull request 132
[https://github.com/apache/bookkeeper/pull/132]
{noformat}
commit de59bd2ad038428cfa61cfdefe1266f3356e1937
Author: eolivelli <eo...@apache.org>
AuthorDate: Tue Apr 18 10:59:33 2017 -0700
Commit: Sijie Guo <si...@apache.org>
CommitDate: Tue Apr 18 10:59:33 2017 -0700
BOOKKEEPER-1039: bk-merge-pr.py ask to run findbugs and rat before merge
Add the ability to optionally run findbugs and apache RAT before every merge using the PR merge script
Author: eolivelli <eo...@apache.org>
Reviewers: Sijie Guo <si...@apache.org>
Closes #132 from eolivelli/BOOKKEEPER-1039-merge-findbugs
{noformat}
> bk-merge-pr.py ask to run findbugs and rat before merge
> -------------------------------------------------------
>
> Key: BOOKKEEPER-1039
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1039
> Project: Bookkeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 4.5.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Critical
> Fix For: 4.5.0
>
>
> The bk-merge-pr.py script currently asks for running "mvn clean install".
> The full test suite is very slow.
> Many times we are merging patches which break findbugs and rat check
> I would like to add a step like
> "Do you want to validate findbugs and rat after the merge? (y/n)"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)