You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/03 17:58:00 UTC
[jira] [Commented] (SOLR-15743) Rewrite v2 config APIs using annotation framework
[ https://issues.apache.org/jira/browse/SOLR-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17546530#comment-17546530 ]
ASF subversion and git services commented on SOLR-15743:
--------------------------------------------------------
Commit f4a71a9c45bbca3b4c5acf2c04de28f30653ecee in solr's branch refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=f4a71a9c45b ]
SOLR-15743: Convert v2 GET /config APIs to annotations (#888)
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API properties.
This commit converts the APIs from the core.config and core.config.Params
apispec file to the "new" framework. However, many other APIs under
/config still remain.
This commit also introduces a slight refactor in the testing for these
sort of annotated APIs: a new test-base (V2ApiMappingTest) that collects
test setup and assertion methods common to many of the v2-mapping test
classes.
> Rewrite v2 config APIs using annotation framework
> -------------------------------------------------
>
> Key: SOLR-15743
> URL: https://issues.apache.org/jira/browse/SOLR-15743
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Reporter: Jason Gerlowski
> Priority: Major
> Labels: V2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Solr's v2 APIs can be implemented in 1 of 2 possible ways: an apispec (i.e. JSON file) based approach that was originally conceived when the v2 APIs were created, and an approach that relies on annotated POJO objects which has come into favor more recently as it results in less duplication and inches our APIs ones step towards a more strongly-typed future.
> The consensus has emerged across several JIRAs that the annotated-POJO approach is the one that should be used going forward, and that existing v2 APIs should be cut over as convenient.
> It's worth noting that this will cause the introspection output to lose the "description" text for these APIs and their parameters, as there's no support for this yet for annotation-based v2 APIs. See SOLR-15117 for more details.
> This ticket aims to tackle this conversion for the /v2/collections/<collName>/config API.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org