You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/10 08:02:56 UTC
[GitHub] [rocketmq-mqtt] shendongsd opened a new pull request, #95: To support Will Message Feature
shendongsd opened a new pull request, #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95
[#69 ](https://github.com/apache/rocketmq-mqtt/issues/69) To support Will Message Feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] pingww commented on pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
pingww commented on PR #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95#issuecomment-1124767061
Could you write a detailed design proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] tianliuliu commented on pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
tianliuliu commented on PR #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95#issuecomment-1123121895
please fix the Travis CI check, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] pingww closed pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
pingww closed pull request #95: To support Will Message Feature
URL: https://github.com/apache/rocketmq-mqtt/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on a diff in pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on code in PR #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95#discussion_r871187040
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java:
##########
@@ -287,6 +288,18 @@ private void addSubscriptionAndInit(Session session, Set<Subscription> subscript
}
}
+ @Override
+ public void addWillMessage(String channelId, WillMessage willMessage) {
+ Session session = getSession(channelId);
+ if (session == null) {
+ return;
+ }
+ if (willMessage == null) {
+ return;
+ }
+ session.setWillMessage(willMessage);
Review Comment:
Will message lose when the mqtt server down.
FYI, http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718028 in 3.1.2.5
"In the case of a Server shutdown or failure the server MAY defer publication of Will Messages until a subsequent restart. If this happens there might be a delay between the time the server experienced failure and a Will Message being published."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] zongtanghu commented on pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on PR #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95#issuecomment-1214138823
I see this pr's code has some codes' conflicts, you can rebase it. And you should link your supporting will messaging design doc here! @shendongsd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] zongtanghu commented on pull request #95: To support Will Message Feature
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on PR #95:
URL: https://github.com/apache/rocketmq-mqtt/pull/95#issuecomment-1214138461
@shendongsd Could you modify this pr as other members' suggetions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org