[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8606: [C++] fix cpp client do AcknowledgeCumulative not clean up previous message

[GitBox <gi...@apache.org>]

BewareMyPower commented on a change in pull request #8606:
URL: https://github.com/apache/pulsar/pull/8606#discussion_r532719627



##########
File path: pulsar-client-cpp/lib/UnAckedMessageTrackerEnabled.h
##########
@@ -25,25 +25,27 @@
 namespace pulsar {
 class UnAckedMessageTrackerEnabled : public UnAckedMessageTrackerInterface {
    public:
-    ~UnAckedMessageTrackerEnabled();
+       virtual ~UnAckedMessageTrackerEnabled() { this->close(); }

Review comment:
       It won't pass the clang-format check here. Please use clang-format 5.0 to reformat your code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org