You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2022/02/28 12:32:05 UTC
Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/
-----------------------------------------------------------
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
Bugs: RANGER-3389
https://issues.apache.org/jira/browse/RANGER-3389
Repository: ranger
Description
-------
Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
Diffs
-----
distro/src/main/assembly/admin-web.xml e19d50572
docs/src/site/resources/index.html PRE-CREATION
docs/src/site/resources/index.js PRE-CREATION
docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
docs/src/site/resources/swagger-ui.css PRE-CREATION
docs/src/site/resources/swagger-ui.js PRE-CREATION
enunciate.xml 13b465b55
pom.xml 8a19c2de4
security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
Diff: https://reviews.apache.org/r/73869/diff/1/
Testing
-------
Updated Review request form https://reviews.apache.org/r/73566/
Fixed issue where swagger UI is not loading.
Fixed all review comment on patch.
Thanks,
Dhaval Rajpara
Re: Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
Posted by Dhaval Rajpara <dh...@gmail.com>.
> On April 14, 2022, 7:09 p.m., Nitin Galave wrote:
> > security-admin/src/main/webapp/scripts/modules/RestCsrf.js
> > Lines 89 (patched)
> > <https://reviews.apache.org/r/73869/diff/2/?file=2267205#file2267205line89>
> >
> > Can we clear csrfToken when user logout?
Hi Nitin,
There are other attributes also present in local storage that also needs to be clear so created JIRA for that RANGER-3720 and this will also handle in that.
- Dhaval
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/#review224321
-----------------------------------------------------------
On April 4, 2022, 9 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73869/
> -----------------------------------------------------------
>
> (Updated April 4, 2022, 9 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3389
> https://issues.apache.org/jira/browse/RANGER-3389
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/admin-web.xml e19d50572
> docs/src/site/resources/index.html PRE-CREATION
> docs/src/site/resources/index.js PRE-CREATION
> docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
> docs/src/site/resources/swagger-ui.css PRE-CREATION
> docs/src/site/resources/swagger-ui.js PRE-CREATION
> enunciate.xml 13b465b55
> pom.xml 252463227
> security-admin/src/main/webapp/scripts/modules/RestCsrf.js 63561e3d1
> security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
>
>
> Diff: https://reviews.apache.org/r/73869/diff/2/
>
>
> Testing
> -------
>
> Updated Review request form https://reviews.apache.org/r/73566/
> Fixed issue where swagger UI is not loading.
> Fixed all review comment on patch.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
Posted by Nitin Galave <ni...@gmail.com>.
> On April 14, 2022, 7:09 p.m., Nitin Galave wrote:
> > security-admin/src/main/webapp/scripts/modules/RestCsrf.js
> > Lines 89 (patched)
> > <https://reviews.apache.org/r/73869/diff/2/?file=2267205#file2267205line89>
> >
> > Can we clear csrfToken when user logout?
>
> Dhaval Rajpara wrote:
> Hi Nitin,
>
> There are other attributes also present in local storage that also needs to be clear so created JIRA for that RANGER-3720 and this will also handle in that.
ok thanks
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/#review224321
-----------------------------------------------------------
On April 4, 2022, 9 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73869/
> -----------------------------------------------------------
>
> (Updated April 4, 2022, 9 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3389
> https://issues.apache.org/jira/browse/RANGER-3389
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/admin-web.xml e19d50572
> docs/src/site/resources/index.html PRE-CREATION
> docs/src/site/resources/index.js PRE-CREATION
> docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
> docs/src/site/resources/swagger-ui.css PRE-CREATION
> docs/src/site/resources/swagger-ui.js PRE-CREATION
> enunciate.xml 13b465b55
> pom.xml 252463227
> security-admin/src/main/webapp/scripts/modules/RestCsrf.js 63561e3d1
> security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
>
>
> Diff: https://reviews.apache.org/r/73869/diff/2/
>
>
> Testing
> -------
>
> Updated Review request form https://reviews.apache.org/r/73566/
> Fixed issue where swagger UI is not loading.
> Fixed all review comment on patch.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/#review224321
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/modules/RestCsrf.js
Lines 89 (patched)
<https://reviews.apache.org/r/73869/#comment313177>
Can we clear csrfToken when user logout?
- Nitin Galave
On April 4, 2022, 9 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73869/
> -----------------------------------------------------------
>
> (Updated April 4, 2022, 9 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3389
> https://issues.apache.org/jira/browse/RANGER-3389
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/admin-web.xml e19d50572
> docs/src/site/resources/index.html PRE-CREATION
> docs/src/site/resources/index.js PRE-CREATION
> docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
> docs/src/site/resources/swagger-ui.css PRE-CREATION
> docs/src/site/resources/swagger-ui.js PRE-CREATION
> enunciate.xml 13b465b55
> pom.xml 252463227
> security-admin/src/main/webapp/scripts/modules/RestCsrf.js 63561e3d1
> security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
>
>
> Diff: https://reviews.apache.org/r/73869/diff/2/
>
>
> Testing
> -------
>
> Updated Review request form https://reviews.apache.org/r/73566/
> Fixed issue where swagger UI is not loading.
> Fixed all review comment on patch.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/#review224370
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Galave
On April 4, 2022, 9 a.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73869/
> -----------------------------------------------------------
>
> (Updated April 4, 2022, 9 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3389
> https://issues.apache.org/jira/browse/RANGER-3389
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/admin-web.xml e19d50572
> docs/src/site/resources/index.html PRE-CREATION
> docs/src/site/resources/index.js PRE-CREATION
> docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
> docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
> docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
> docs/src/site/resources/swagger-ui.css PRE-CREATION
> docs/src/site/resources/swagger-ui.js PRE-CREATION
> enunciate.xml 13b465b55
> pom.xml 252463227
> security-admin/src/main/webapp/scripts/modules/RestCsrf.js 63561e3d1
> security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
>
>
> Diff: https://reviews.apache.org/r/73869/diff/2/
>
>
> Testing
> -------
>
> Updated Review request form https://reviews.apache.org/r/73566/
> Fixed issue where swagger UI is not loading.
> Fixed all review comment on patch.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>
Re: Review Request 73869: RANGER-3389 : Swagger UI Support for Ranger REST API.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73869/
-----------------------------------------------------------
(Updated April 4, 2022, 9 a.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Pradeep Agrawal, Sailaja Polavarapu, Steven Ramirez, and Velmurugan Periasamy.
Bugs: RANGER-3389
https://issues.apache.org/jira/browse/RANGER-3389
Repository: ranger
Description
-------
Create documentation for ranger REST API then display that documentation through swagger ui as part of ranger admin ui.
Diffs (updated)
-----
distro/src/main/assembly/admin-web.xml e19d50572
docs/src/site/resources/index.html PRE-CREATION
docs/src/site/resources/index.js PRE-CREATION
docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION
docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION
docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION
docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION
docs/src/site/resources/swagger-ui.css PRE-CREATION
docs/src/site/resources/swagger-ui.js PRE-CREATION
enunciate.xml 13b465b55
pom.xml 252463227
security-admin/src/main/webapp/scripts/modules/RestCsrf.js 63561e3d1
security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617
Diff: https://reviews.apache.org/r/73869/diff/2/
Changes: https://reviews.apache.org/r/73869/diff/1-2/
Testing
-------
Updated Review request form https://reviews.apache.org/r/73566/
Fixed issue where swagger UI is not loading.
Fixed all review comment on patch.
Thanks,
Dhaval Rajpara