You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by shikhar <gi...@git.apache.org> on 2016/12/08 23:23:59 UTC

[GitHub] kafka pull request #2232: HOTFIX: Fix HerderRequest.compareTo()

GitHub user shikhar opened a pull request:

    https://github.com/apache/kafka/pull/2232

    HOTFIX: Fix HerderRequest.compareTo()

    With KAFKA-3008 (#1788), the implementation does not respect the contract that 'sgn(x.compareTo(y)) == -sgn(y.compareTo(x))'
    
    This fix addresses the hang with JDK8 in DistributedHerderTest.compareTo()

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shikhar/kafka herderreq-compareto

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2232
    
----
commit 4c5a8102a340478509a1c9331bf53ceccac394fb
Author: Shikhar Bhushan <sh...@confluent.io>
Date:   2016-12-08T23:18:59Z

    HOTFIX: Fix HerderRequest.compareTo()
    
    With KAFKA-3008 (#1788), the implementation does not respect the contract that 'sgn(x.compareTo(y)) == -sgn(y.compareTo(x))'
    
    This fix addresses the hang with JDK8 in DistributedHerderTest.compareTo()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2232: HOTFIX: Fix HerderRequest.compareTo()

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---