You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/09 18:26:12 UTC

[GitHub] bmeriaux edited a comment on issue #6813: [FLINK-10440] Add a new CassandraPojoOutputFormat

bmeriaux edited a comment on issue #6813: [FLINK-10440] Add a new CassandraPojoOutputFormat
URL: https://github.com/apache/flink/pull/6813#issuecomment-428299042
 
 
   Hi,
   I need you advice on the inheritance with `CassandraOutputFormatBase`, because `CassandraOutputFormatBase` constructor need an insert query, which i do not have in the `CassandraPojoOutputFormat`.
   I choose the duplication option.
   What do you think about pull up Row/Tuple specific code to their classes and refactor the `CassandraOutputFormatBase` with only common code? if any user have made some inheritence of the base class it will break, is it considered as a breaking change ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services