[jira] [Reopened] (CB-1957) InAppBrowser - video/audio does not stop playing when browser is closed

["Andrew Grieve (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve reopened CB-1957:
-------------------------------

      Assignee: Andrew Grieve  (was: Shazron Abdullah)

Yep, let's just re-open. That said - I made a change today to release the webview when it closes, so that has a chance of fixing this:

https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=blobdiff;f=CordovaLib/Classes/CDVInAppBrowser.m;h=3e1beeae09ffc73a558023662df54fcd22347db7;hp=6c87d45dff6f570d4c2e397f7f19d124e9292202;hb=07a223ee65add7e5e6ff108a77fbc684dad79914;hpb=92fa3e4538f7d96117c507dfb89c4e5d388ec6dd


Maybe you could try and see if this fixes the problem? I'll paste here for you:

- (void)browserExit
{
    if (self.callbackId != nil) {
        CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK
                                                      messageAsDictionary:@ {@"type":@"exit"}];
        [pluginResult setKeepCallback:[NSNumber numberWithBool:YES]];

        [self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackId];
    }

/// THIS IS THE NEW PART ///

    // Don't recycle the ViewController since it may be consuming a lot of memory.
    // Also - this is required for the PDF/User-Agent bug work-around.
    self.inAppBrowserViewController = nil;
}

                
> InAppBrowser - video/audio does not stop playing when browser is closed
> -----------------------------------------------------------------------
>
>                 Key: CB-1957
>                 URL: https://issues.apache.org/jira/browse/CB-1957
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Andrew Grieve
>             Fix For: 2.3.0
>
>         Attachments: video.html
>
>
> Repro:
> 1. Load a YouTube video (with audio track) in the InAppBrowser, play it
> 2. Close InAppBrowser
> Expected result:
> Audio stops playing
> Actual result:
> Audio continues playing
> The simple fix is to loadHTMLString:nil on the InAppBrowser UIWebView when the view disappears, but the real reason is probably because the UIWebView instance has not been released.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira