You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2006/10/03 09:18:19 UTC
[jira] Created: (QPID-11) Move protocol literals from code to
AMQConstant
Move protocol literals from code to AMQConstant
-----------------------------------------------
Key: QPID-11
URL: http://issues.apache.org/jira/browse/QPID-11
Project: Qpid
Issue Type: Improvement
Components: Java Broker, Java Client
Reporter: Martin Ritchie
Priority: Trivial
The current Java code has the odd literal value. Such as this from AMQMessage:
return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
&&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
What is deliverymode 2?
Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (QPID-11) Move protocol literals from code to
AMQConstant
Posted by "Kim van der Riet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463069 ]
Kim van der Riet commented on QPID-11:
--------------------------------------
All constants defined as part of the XML are now being generated into a file AmqpConstants.java. Since there is no type associated with these XML constant declarations, each constant comes in three flavours: String, int and double. If the constant contains non-numeric characters, the int and double versions are supressed. If the constant contails a decimal '.', then the int version is suppressed. All are static members of class AmqpConstants.
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: https://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Reporter: Martin Ritchie
> Priority: Trivial
> Fix For: M2
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (QPID-11) Move protocol literals from code to
AMQConstant
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-11:
---------------------------------
Fix Version/s: (was: M2)
M3
Affects Version/s: M2
M1
Moving unresolved JIRAs from M2 to M3, in preparation for M2 release
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: https://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Affects Versions: M1, M2
> Reporter: Martin Ritchie
> Priority: Trivial
> Fix For: M3
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (QPID-11) Move protocol literals from code to
AMQConstant
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey closed QPID-11.
---------------------------
Will not fix : Constants replaced by enums in 0-10
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: https://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Affects Versions: M1, M2
> Reporter: Martin Ritchie
> Priority: Trivial
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-11) Move protocol literals from code to
AMQConstant
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-11.
-----------------------------
Resolution: Won't Fix
Fix Version/s: (was: M3)
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: https://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Affects Versions: M1, M2
> Reporter: Martin Ritchie
> Priority: Trivial
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-11) Move protocol literals from code to
AMQConstant
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/QPID-11?page=all ]
Marnie McCormack updated QPID-11:
---------------------------------
Fix Version/s: M2
> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
> Key: QPID-11
> URL: http://issues.apache.org/jira/browse/QPID-11
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Reporter: Martin Ritchie
> Priority: Trivial
> Fix For: M2
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
> return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
> &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand. Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira