You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/04/19 03:05:31 UTC
[GitHub] incubator-beam pull request: [BEAM-22] Track Pending Elements via ...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/207
[BEAM-22] Track Pending Elements via Exploded WindowedValues
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This allows the WindowedValues that are completed to be
removed from the set of pending elements, even if the actual object
is a different instance, by ensuring that all WindowedValues contain
only a single (element, window) pair.
Built on top of #206
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam ippr_exploded_wm_tracking
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit ac0696d8867d7a1706f1ff85c4b299c2b1779d02
Author: Thomas Groh <tg...@google.com>
Date: 2016-04-18T23:55:57Z
Add WindowedValue#explodeWindows
This takes an existing WindowedValue and returns a Collection of
WindowedValues, each of which is in exactly one window.
Use the explode implementation on DoFnRunnerBase
commit 725b2ddea58add3f583ed6f7c74f6ab4343cf292
Author: Thomas Groh <tg...@google.com>
Date: 2016-04-19T00:28:47Z
Track pending elements via exploded WindowedValues
This allows the WindowedValues to be partially completed while the
still holding the watermark.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request: [BEAM-22] Track Pending Elements via ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---