You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/25 15:01:00 UTC

[GitHub] [flink] rkhachatryan commented on a diff in pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout

rkhachatryan commented on code in PR #19819:
URL: https://github.com/apache/flink/pull/19819#discussion_r881765652


##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/TestJobExecutor.java:
##########
@@ -77,28 +77,28 @@ private TestJobExecutor(
     public static TestJobExecutor execute(
             TestJobWithDescription testJob, MiniClusterWithClientResource miniClusterResource)
             throws Exception {
-        LOG.debug("submitGraph: {}", testJob.jobGraph);
+        LOG.info("submitGraph: {}", testJob.jobGraph);
         JobID job = miniClusterResource.getClusterClient().submitJob(testJob.jobGraph).get();
         waitForAllTaskRunning(miniClusterResource.getMiniCluster(), job, false);
         return new TestJobExecutor(testJob, job, miniClusterResource);
     }
 
     public TestJobExecutor waitForAllRunning() throws Exception {
-        LOG.debug("waitForAllRunning in {}", jobID);
+        LOG.info("waitForAllRunning in {}", jobID);

Review Comment:
   I think it should be actually info because this is some test execution phase.
   Besides that, changing in tools/ci/log4j.properties would only help when running on CI, not locally for example.
   
   So I'd rather keep it `info` in code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org