You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladimirg-db (via GitHub)" <gi...@apache.org> on 2025/10/25 21:23:09 UTC

[PR] [SQL][SPARK-54031] Add new golden file tests for analysis edge-cases [spark]

vladimirg-db opened a new pull request, #52733:
URL: https://github.com/apache/spark/pull/52733

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   
   Add new golden file tests for analysis edge-cases discovered during Analyzer support and development.
   
   ### Why are the changes needed?
   
   Harden Spark testing coverage.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Test-only change.
   
   ### How was this patch tested?
   
   Adding new golden files.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes, Claude triaged the test cases across the golden files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SQL][SPARK-54031] Add new golden file tests for analysis edge-cases [spark]

Posted by "vladimirg-db (via GitHub)" <gi...@apache.org>.
vladimirg-db closed pull request #52733: [SQL][SPARK-54031] Add new golden file tests for analysis edge-cases
URL: https://github.com/apache/spark/pull/52733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org