You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ryan Holmes (JIRA)" <ta...@jakarta.apache.org> on 2006/04/29 22:41:37 UTC
[jira] Created: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
SimpleTableColumnComponent.html contains invalid CSS
----------------------------------------------------
Key: TAPESTRY-932
URL: http://issues.apache.org/jira/browse/TAPESTRY-932
Project: Tapestry
Type: Bug
Components: Contrib
Versions: 4.0.1
Environment: Windows/Firefox
Reporter: Ryan Holmes
Priority: Minor
Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Resolved: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-932?page=all ]
Brian K. Wallace resolved TAPESTRY-932:
---------------------------------------
Resolution: Fixed
Removed embedded style
> SimpleTableColumnComponent.html contains invalid CSS
> ----------------------------------------------------
>
> Key: TAPESTRY-932
> URL: http://issues.apache.org/jira/browse/TAPESTRY-932
> Project: Tapestry
> Type: Bug
> Components: Contrib
> Versions: 4.0.1
> Environment: Windows/Firefox
> Reporter: Ryan Holmes
> Assignee: Brian K. Wallace
> Priority: Minor
> Fix For: 4.0.3
>
> Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
> If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
> Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Updated: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-932?page=all ]
Brian K. Wallace updated TAPESTRY-932:
--------------------------------------
Fix Version: 4.0.3
Assign To: Brian K. Wallace
> SimpleTableColumnComponent.html contains invalid CSS
> ----------------------------------------------------
>
> Key: TAPESTRY-932
> URL: http://issues.apache.org/jira/browse/TAPESTRY-932
> Project: Tapestry
> Type: Bug
> Components: Contrib
> Versions: 4.0.1
> Environment: Windows/Firefox
> Reporter: Ryan Holmes
> Assignee: Brian K. Wallace
> Priority: Minor
> Fix For: 4.0.3
>
> Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
> If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
> Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Commented: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-932?page=comments#action_12377129 ]
Brian K. Wallace commented on TAPESTRY-932:
-------------------------------------------
I'll look at this, but I'm thinking that fixing the CSS would be preferable to provide a 'sensible default'. If it's suitable for a majority of the users, yet overridable for the rest, it's a good thing in my opinion.
> SimpleTableColumnComponent.html contains invalid CSS
> ----------------------------------------------------
>
> Key: TAPESTRY-932
> URL: http://issues.apache.org/jira/browse/TAPESTRY-932
> Project: Tapestry
> Type: Bug
> Components: Contrib
> Versions: 4.0.1
> Environment: Windows/Firefox
> Reporter: Ryan Holmes
> Priority: Minor
>
> Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
> If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
> Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Commented: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
Posted by "Leonardo Quijano Vincenzi (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-932?page=comments#action_12377130 ]
Leonardo Quijano Vincenzi commented on TAPESTRY-932:
----------------------------------------------------
But isn't local styles more relevant that CSS files? I'm thinking it may be not overridable if a local style is applied there.
And... is it XHTML compatible?
> SimpleTableColumnComponent.html contains invalid CSS
> ----------------------------------------------------
>
> Key: TAPESTRY-932
> URL: http://issues.apache.org/jira/browse/TAPESTRY-932
> Project: Tapestry
> Type: Bug
> Components: Contrib
> Versions: 4.0.1
> Environment: Windows/Firefox
> Reporter: Ryan Holmes
> Priority: Minor
>
> Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
> If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
> Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Commented: (TAPESTRY-932) SimpleTableColumnComponent.html
contains invalid CSS
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-932?page=comments#action_12377131 ]
Brian K. Wallace commented on TAPESTRY-932:
-------------------------------------------
Embedded styles take priority over linked. That's the closest I can vouch for. Linked from two places? The second would override the first.. The problem with any CSS change combines "embedded vs. linked" as well as "users who do not use CSS themselves".
Hadn't planned on looking just yet, but I did and see the style embedded which would always take precedence. I'll look at removing it.
This also affects SimpleTableColumnFormComponent (Those are the only two which have embedded styles in framework or contrib)
> SimpleTableColumnComponent.html contains invalid CSS
> ----------------------------------------------------
>
> Key: TAPESTRY-932
> URL: http://issues.apache.org/jira/browse/TAPESTRY-932
> Project: Tapestry
> Type: Bug
> Components: Contrib
> Versions: 4.0.1
> Environment: Windows/Firefox
> Reporter: Ryan Holmes
> Priority: Minor
>
> Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.
> If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").
> Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org